From: Michael Ellerman <mpe@ellerman.id.au>
To: Zhao Qiang <qiang.zhao@nxp.com>, tglx@linutronix.de
Cc: oss@buserror.net, Zhao Qiang <qiang.zhao@nxp.com>,
linuxppc-dev@lists.ozlabs.org, xiaobo.xie@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC
Date: Mon, 07 Aug 2017 17:02:11 +1000 [thread overview]
Message-ID: <87h8xjq2rw.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1502075236-24078-5-git-send-email-qiang.zhao@nxp.com>
Zhao Qiang <qiang.zhao@nxp.com> writes:
> QEIC was supported on PowerPC, and dependent on PPC,
> Now it is supported on other platforms, so remove PPCisms.
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> arch/powerpc/platforms/83xx/km83xx.c | 1 -
> arch/powerpc/platforms/83xx/misc.c | 1 -
> arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 -
> arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 -
> arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 -
> arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 -
> arch/powerpc/platforms/85xx/corenet_generic.c | 1 -
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 -
> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 1 -
> arch/powerpc/platforms/85xx/twr_p102x.c | 1 -
> drivers/irqchip/irq-qeic.c | 188 +++++++++++---------------
> include/soc/fsl/qe/qe_ic.h | 132 ------------------
> 12 files changed, 80 insertions(+), 250 deletions(-)
> delete mode 100644 include/soc/fsl/qe/qe_ic.h
>
> diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c
> index d8642a4..b1cef0a 100644
> --- a/arch/powerpc/platforms/83xx/km83xx.c
> +++ b/arch/powerpc/platforms/83xx/km83xx.c
> @@ -38,7 +38,6 @@
> #include <sysdev/fsl_soc.h>
> #include <sysdev/fsl_pci.h>
> #include <soc/fsl/qe/qe.h>
> -#include <soc/fsl/qe/qe_ic.h>
You deleted that file in patch 2. So didn't you just break the build for
the last two commits?
cheers
next prev parent reply other threads:[~2017-08-07 7:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 3:07 [PATCH v10 0/4] this patchset is to " Zhao Qiang
2017-08-07 3:07 ` [PATCH v10 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe Zhao Qiang
2017-08-07 3:07 ` [PATCH v10 2/4] irqchip/qeic: merge qeic init code from platforms to a common function Zhao Qiang
2017-08-07 3:07 ` [PATCH v10 3/4] irqchip/qeic: merge qeic_of_init into qe_ic_init Zhao Qiang
2017-08-07 3:07 ` [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC Zhao Qiang
2017-08-07 7:02 ` Michael Ellerman [this message]
2017-08-08 6:21 ` Qiang Zhao
2017-08-08 10:04 ` Michael Ellerman
2017-08-09 2:35 ` Qiang Zhao
2017-10-24 1:51 ` [PATCH v10 0/4] this patchset is to " Qiang Zhao
2017-10-31 3:06 ` Qiang Zhao
2017-11-01 0:54 ` Michael Ellerman
2017-11-01 1:39 ` Qiang Zhao
2017-11-01 17:09 ` Thomas Gleixner
2017-11-02 1:41 ` Qiang Zhao
2017-11-02 10:12 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8xjq2rw.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=tglx@linutronix.de \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®