From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdBBXzl (ORCPT ); Thu, 2 Feb 2017 18:55:41 -0500 Received: from ozlabs.org ([103.22.144.67]:44181 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdBBXzk (ORCPT ); Thu, 2 Feb 2017 18:55:40 -0500 From: Michael Ellerman To: Borislav Petkov , Chris Packham Cc: "linux-edac\@vger.kernel.org" , "morbidrsa\@gmail.com" , Rob Herring , Mark Rutland , Benjamin Herrenschmidt , Paul Mackerras , Mauro Carvalho Chehab , "devicetree\@vger.kernel.org" , "linuxppc-dev\@lists.ozlabs.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2] EDAC: mpc85xx: Add T2080 l2-cache support In-Reply-To: <20170202173005.gqesvy5owtsbrviu@pd.tnic> References: <20170201231624.28843-1-chris.packham@alliedtelesis.co.nz> <20170201232735.byk7bnpeoqtcc7mh@pd.tnic> <01fe1af463c640a8bd48e45c2752b52c@svr-chch-ex1.atlnz.lc> <20170202173005.gqesvy5owtsbrviu@pd.tnic> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 03 Feb 2017 10:55:33 +1100 Message-ID: <87h94cb11m.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Wed, Feb 01, 2017 at 11:46:23PM +0000, Chris Packham wrote: >> >> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c >> >> index 8f66cbed70b7..67f7bc3fe5b3 100644 >> >> --- a/drivers/edac/mpc85xx_edac.c >> >> +++ b/drivers/edac/mpc85xx_edac.c >> >> @@ -629,6 +629,7 @@ static const struct of_device_id mpc85xx_l2_err_of_match[] = { >> >> { .compatible = "fsl,p1020-l2-cache-controller", }, >> >> { .compatible = "fsl,p1021-l2-cache-controller", }, >> >> { .compatible = "fsl,p2020-l2-cache-controller", }, >> >> + { .compatible = "fsl,t2080-l2-cache-controller", }, >> > >> > WARNING: DT compatible string "fsl,t2080-l2-cache-controller" appears un-documented -- check ./Documentation/devicetree/bindings/ >> > #58: FILE: drivers/edac/mpc85xx_edac.c:632: >> > + { .compatible = "fsl,t2080-l2-cache-controller", }, >> > >> > What is checkpatch.pl trying to tell me here? >> > >> >> checpkatch.pl is confused by >> Documentation/devicetree/bindings/powerpc/fsl/l2cache.txt which says >> >> - compatible : Should include "fsl,chip-l2-cache-controller" and "cache" >> where chip is the processor (bsc9132, npc8572 etc.) >> >> So none of the fsl cache controllers pass the checkpatch.pl test. > > Hmm, so others do list those names explicitly. For example: > > Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt > > And the patch that added that check to cp: > > bff5da433525 ("checkpatch: add DT compatible string documentation checks") > > is basically to enforce explicit compatible names. > > So I'd like to have an ACK from a PPC maintainer here first before I > apply this. It's fine with me: Acked-by: Michael Ellerman Chris if you want to send a patch to add the compatible string to the l2cache.txt I would merge that, but honestly it doesn't achieve much other than possibly catching a typo in the compatible name. cheers