From: Michael Ellerman <mpe@ellerman.id.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Burton <paul.burton@imgtec.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Thorsten Leemhuis <regressions@leemhuis.info>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "console: don't prefer first registered if DT specifies stdout-path"
Date: Tue, 08 Nov 2016 11:46:35 +1100 [thread overview]
Message-ID: <87h97ilrx0.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161104121135.4780-2-hdegoede@redhat.com>
Hans de Goede <hdegoede@redhat.com> writes:
> This reverts commit 05fd007e4629 ("console: don't prefer first registered
> if DT specifies stdout-path").
>
> The reverted commit changes existing behavior on which many ARM boards
> rely. Many ARM small-board-computers, like e.g. the Raspberry Pi have
> both a video output and a serial console. Depending on whether the user
> is using the device as a more regular computer; or as a headless device
> we need to have the console on either one or the other.
>
> Many users rely on the kernel behavior of the console being present on
> both outputs, before the reverted commit the console setup with no
> console= kernel arguments on an ARM board which sets stdout-path in dt
> would look like this:
>
> [root@localhost ~]# cat /proc/consoles
> ttyS0 -W- (EC p a) 4:64
> tty0 -WU (E p ) 4:1
>
> Where as after the reverted commit, it looks like this:
>
> [root@localhost ~]# cat /proc/consoles
> ttyS0 -W- (EC p a) 4:64
>
> This commit reverts commit 05fd007e4629 ("console: don't prefer first
> registered if DT specifies stdout-path") restoring the original behavior.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This is also breaking various powerpc systems.
Linus can you please merge this revert for 4.9 ?
cheers
next prev parent reply other threads:[~2016-11-08 0:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 12:11 [REGRESSION] "console: don't prefer first registered if DT specifies stdout-path" breaks console on video outputs of various ARM boards Hans de Goede
2016-11-04 12:11 ` [PATCH] Revert "console: don't prefer first registered if DT specifies stdout-path" Hans de Goede
2016-11-04 19:39 ` Andrew Morton
2016-11-08 0:46 ` Michael Ellerman [this message]
2016-11-08 7:00 ` Greg Kroah-Hartman
2016-11-10 14:14 ` Greg Kroah-Hartman
2016-11-04 12:30 ` [REGRESSION] "console: don't prefer first registered if DT specifies stdout-path" breaks console on video outputs of various ARM boards Paul Burton
2016-11-04 13:22 ` Hans de Goede
2016-11-05 10:40 ` Paul Burton
2016-11-06 10:54 ` Hans de Goede
2016-11-07 17:16 ` Paul Burton
2016-11-08 9:12 ` Hans de Goede
2016-11-05 11:00 ` Paul Burton
2016-11-06 12:13 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h97ilrx0.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=regressions@leemhuis.info \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome