From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644AbcHHV32 (ORCPT ); Mon, 8 Aug 2016 17:29:28 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:38842 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbcHHV30 (ORCPT ); Mon, 8 Aug 2016 17:29:26 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Linux Containers Cc: Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Seth Forshee , Nikolay Borisov , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jann Horn , Andrei Vagin , Colin Walters , "Michael Kerrisk \(man-pages\)" References: <8737n5dscy.fsf@x220.int.ebiederm.org> <87d1m754jc.fsf@x220.int.ebiederm.org> Date: Mon, 08 Aug 2016 16:16:08 -0500 In-Reply-To: <87d1m754jc.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Thu, 21 Jul 2016 11:39:35 -0500") Message-ID: <87h9avneqv.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1bWs6r-0000Q3-6x;;;mid=<87h9avneqv.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=67.3.204.119;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/En24vsgEC5v7HLqYa6iX5xurTjXtC028= X-SA-Exim-Connect-IP: 67.3.204.119 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Linux Containers X-Spam-Relay-Country: X-Spam-Timing: total 477 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 4.1 (0.9%), b_tie_ro: 3.0 (0.6%), parse: 1.17 (0.2%), extract_message_metadata: 3.7 (0.8%), get_uri_detail_list: 1.21 (0.3%), tests_pri_-1000: 7 (1.4%), tests_pri_-950: 2.1 (0.4%), tests_pri_-900: 1.65 (0.3%), tests_pri_-400: 27 (5.6%), check_bayes: 25 (5.3%), b_tokenize: 9 (1.9%), b_tok_get_all: 7 (1.4%), b_comp_prob: 3.0 (0.6%), b_tok_touch_all: 3.0 (0.6%), b_finish: 0.96 (0.2%), tests_pri_0: 403 (84.5%), check_dkim_signature: 0.84 (0.2%), check_dkim_adsp: 4.5 (0.9%), tests_pri_500: 6 (1.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2 00/10] userns: sysctl limits for namespaces X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I won't have any more time for this until I return from vacation at the end of the month but after a little bit of thought I think I have fixed all of the bugs (except arguably the return value). I have further tweaked these and made the limits per user. Because it occured to me that if the limits are global it is possible for one misbehaving user to DOS another which is undesirable in princible. I have put my updated code at: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-testing Eric