From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933303AbcHDJqG (ORCPT ); Thu, 4 Aug 2016 05:46:06 -0400 Received: from ozlabs.org ([103.22.144.67]:36819 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933209AbcHDJqE (ORCPT ); Thu, 4 Aug 2016 05:46:04 -0400 From: Michael Ellerman To: Hari Bathini , rusty@rustcorp.com.au, ebiederm@xmission.com, vgoyal@redhat.com, linuxppc-dev Cc: Mahesh J Salgaonkar , kexec@lists.infradead.org, lkml , Ananth N Mavinakayanahalli Subject: Re: [RESEND][PATCH v2 2/2] powerpc/fadump: parse fadump reserve memory size based on memory range In-Reply-To: <147025281599.29229.9962999599360876220.stgit@hbathini.in.ibm.com> References: <147025270324.29229.8322429758761407397.stgit@hbathini.in.ibm.com> <147025281599.29229.9962999599360876220.stgit@hbathini.in.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 04 Aug 2016 19:45:28 +1000 Message-ID: <87h9b0g953.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hari Bathini writes: ... > /** > * fadump_calculate_reserve_size(): reserve variable boot area 5% of System RAM > * > @@ -212,12 +262,17 @@ static inline unsigned long fadump_calculate_reserve_size(void) > { > unsigned long size; > > + /* sets fw_dump.reserve_bootvar */ > + parse_fadump_reserve_mem(); > + > /* > * Check if the size is specified through fadump_reserve_mem= cmdline > * option. If yes, then use that. > */ > if (fw_dump.reserve_bootvar) > return fw_dump.reserve_bootvar; > + else > + printk(KERN_INFO "fadump: calculating default boot size\n"); > > /* divide by 20 to get 5% of value */ > size = memblock_end_of_DRAM() / 20; The code already knows how to reserve 5% based on the size of the machine's memory, as long as no commandline parameter is passed. So why can't we just use that logic? cheers