From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbcFJAVk (ORCPT ); Thu, 9 Jun 2016 20:21:40 -0400 Received: from anholt.net ([50.246.234.109]:56860 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbcFJAVj (ORCPT ); Thu, 9 Jun 2016 20:21:39 -0400 From: Eric Anholt To: Catalin Marinas Cc: Gerd Hoffmann , Will Deacon , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, open list Subject: Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835. In-Reply-To: <20160608091219.GA16322@e104818-lin.cambridge.arm.com> References: <1464934708-24769-1-git-send-email-kraxel@redhat.com> <1464934708-24769-5-git-send-email-kraxel@redhat.com> <20160603112721.GC1128@e104818-lin.cambridge.arm.com> <87bn3gu3to.fsf@eliezer.anholt.net> <20160608091219.GA16322@e104818-lin.cambridge.arm.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 09 Jun 2016 17:21:35 -0700 Message-ID: <87h9d1x59s.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Catalin Marinas writes: > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote: >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platfo= rms >> >> index 7ef1d05..ea88402 100644 >> >> --- a/arch/arm64/Kconfig.platforms >> >> +++ b/arch/arm64/Kconfig.platforms >> >> @@ -13,6 +13,19 @@ config ARCH_ALPINE >> >> This enables support for the Annapurna Labs Alpine >> >> Soc family. >> >>=20=20 >> >> +config ARCH_BCM2835 >> >> + bool "Broadcom BCM2835 family" >> >> + select ARCH_REQUIRE_GPIOLIB >> >> + select CLKSRC_OF >> >> + select PINCTRL >> >> + select PINCTRL_BCM2835 >> >> + select ARM_AMBA >> >> + select ARM_TIMER_SP804 >> >> + select HAVE_ARM_ARCH_TIMER >> >> + help >> >> + This enables support for the Broadcom BCM2837 SoC. > > Even the BCM number is inconsistent here. Well, given the past chip numbers, we could call the family's Kconfig ARCH_BCM283X, and for now arm64 would only do the 2837 in the family. Back when I was doing 2836, other maintainers agreed that renaming all of the ARCH_BCM2835 in the tree to BCM283X was pointless thrashing. >> >> + This SoC is used in the Raspberry Pi 3 device. >> > >> > I thought we would just use ARCH_BCM, or is it too generic? >>=20 >> Consensus last time around seemed to be to drop adding ARCH_BCM, in >> favor of patch 1 of the series. > > I may have missed that discussion. My point was about consistency with > existing ARCH_* definitions in the arm64 Kconfig.platforms. I can see > why it's easier for you since some drivers are built based on > ARCH_BCM2835. Looking at drivers/clk/bcm/Makefile, there is an > inconsistent mix of CLK_BCM_* and ARCH_BCM_*. I would rather have a new > CLK_BCM2835 that's selected/enabled accordingly (maybe simply depending > on ARCH_BCM). So I introduce a new ARCH_BCM here, that selects the just the 283x family's core drivers? That seems strange, but I'm willing if that's what you want. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXWggPAAoJELXWKTbR/J7oMbgQAKZ1SiXQIAJ14VR6PIO8ddFK 0KPDuh/xg99IpsYk5ranfQchZJm/BDVvQPKtHX3Y/uSGpbA8Lzuf3+cUfExuAC3v rGNVQ+OBeuz6RU5uV4UNDfs/6FSpF8U3devForULYb1mCXQ88wT5oK7iOc7T13uV uJwYVWNV6aPBDhtNNsrna2Nz7CBYXpZTCI0YIIISpunK8tFDjKmyLxImFUxXU2vN Tpyi5oymwuuKXPHe5Ywqd/kwn5wMoQzU36xomlFaRTbLFllH3F3WW+unJYbrMmCv A/dSiLhtcjiTK4IeaBLDDIrbcWwvkPKAZRVq2HepyJqQCadlO3tA05r2uG02Yv+j e0o+5wXd8zP5Y+Xs4G/dvj9W8az0hWsSWPMxh6SQWkfa0Ms+E8XFaVpF2HSldh7q c0vkcGlgVVFbaSn2qI7wa0iluDHu9y7/1OrCpb7LeljjAlt5SMs9RTSvHrb13r30 3t0d84VvRfffvD+7e953+HTTfp5eKz25yIIwYVCCgzHoE9jMNFN/HTD3vTFipCVr Yg550VQQT+ly0kB46nNCozhR6WxCoECej5PnyhxMvvo5iBZCyh/0qxEqunvzq/94 WHZi4PEAI+6rZfTYj5Hodl7TmdopblDmOHUMM6dAnp2MUK50lDXi0JwpGoVbpMBG W++sLljVq6TS4IS8rWb+ =ynLG -----END PGP SIGNATURE----- --=-=-=--