From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757980AbcCUWnB (ORCPT ); Mon, 21 Mar 2016 18:43:01 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:42015 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbcCUWnA (ORCPT ); Mon, 21 Mar 2016 18:43:00 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 21 Mar 2016 23:42:58 +0100 X-ME-IP: 109.222.252.64 From: Robert Jarzmik To: Hans Verkuil Cc: Guennadi Liakhovetski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 0/2] pxa_camera transition to v4l2 standalone device References: <1458421288-22094-1-git-send-email-robert.jarzmik@free.fr> <56EFAD47.8010403@xs4all.nl> <87lh5bmpro.fsf@belgarion.home> <56F077A4.1090808@xs4all.nl> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 21 Mar 2016 23:42:57 +0100 In-Reply-To: <56F077A4.1090808@xs4all.nl> (Hans Verkuil's message of "Mon, 21 Mar 2016 23:37:24 +0100") Message-ID: <87h9fzmozy.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hans Verkuil writes: >> Input ioctls: >> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) >> test VIDIOC_G/S_FREQUENCY: OK (Not Supported) >> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) >> test VIDIOC_ENUMAUDIO: OK (Not Supported) >> fail: v4l2-test-input-output.cpp(418): G_INPUT not supported for a capture device > > ENUM/G/S_INPUT is missing and is required for capture devices. Okay, that one will be easy I think :) It's a mono-sensor mono-videostream IP. I will add that when for RFC v2. >> Format ioctls: >> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK >> test VIDIOC_G/S_PARM: OK (Not Supported) >> test VIDIOC_G_FBUF: OK (Not Supported) >> fail: v4l2-test-formats.cpp(329): pixelformat != V4L2_PIX_FMT_JPEG && colorspace == V4L2_COLORSPACE_JPEG >> fail: v4l2-test-formats.cpp(432): testColorspace(pix.pixelformat, pix.colorspace, pix.ycbcr_enc, pix.quantization) > > The sensor should almost certainly use COLORSPACE_SRGB. Certainly not > COLORSPACE_JPEG. Ah even for YUYV format, I didn't know ... >> Buffer ioctls: >> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK >> fail: v4l2-test-buffers.cpp(571): q.has_expbuf(node) > > You are missing .vidioc_expbuf = vbs_ioctl_expbuf and the vb2 io_mode > VB2_DMABUF. Nope, I have : .vidioc_expbuf = vb2_ioctl_expbuf, vq->io_modes = VB2_MMAP | VB2_DMABUF; So it's something more subtle, and I have a bit of work to understand what. Cheers. -- Robert