mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@mellanox.com>,
	Kevin Smith <kevin.smith@elecsyscorp.com>
Subject: Re: [RFC PATCH net-next 0/3] net: dsa: finer bridging control
Date: Sun, 13 Mar 2016 14:40:16 -0400	[thread overview]
Message-ID: <87h9ga1asv.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160313174713.GC10666@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Sun, Mar 13, 2016 at 01:42:23AM -0500, Vivien Didelot wrote:
>> This patchset renames the bridging routines of the DSA layer, make the
>> unbridging routine return void, and rework the DSA netdev notifier handler,
>> similar to what the Mellanox Spectrum driver does.
>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
>
> Do you think there could be some consolidation of code with Mellanox,
> and other switchdev devices? Moving it into the switchdev core?

We cannot move all this code to switchdev core, because switchdev is
stateless, so there is no place to register the netdevice notifier(s).

But it might be possible to provide a generic switchdev_netdevice_event
helper, using new switchdev operations to check a port device, and
add/del upper devices. I'll think about that.

Thanks!
Vivien

      reply	other threads:[~2016-03-13 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13  6:42 Vivien Didelot
2016-03-13  6:42 ` [RFC PATCH net-next 1/3] net: dsa: rename port_*_bridge routines Vivien Didelot
2016-03-13  6:42 ` [RFC PATCH net-next 2/3] net: dsa: make port_bridge_leave return void Vivien Didelot
2016-03-13  6:42 ` [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier Vivien Didelot
2016-03-13  7:32   ` Ido Schimmel
2016-03-13 13:39     ` Vivien Didelot
2016-03-13  6:49 ` [RFC PATCH net-next 0/3] net: dsa: finer bridging control Vivien Didelot
2016-03-13 17:47 ` Andrew Lunn
2016-03-13 18:40   ` Vivien Didelot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9ga1asv.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@savoirfairelinux.com \
    --cc=kevin.smith@elecsyscorp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®