From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753825AbbJFP2F (ORCPT ); Tue, 6 Oct 2015 11:28:05 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:36483 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbbJFP2B (ORCPT ); Tue, 6 Oct 2015 11:28:01 -0400 From: Rasmus Villemoes To: Bart Van Assche Cc: Christoph Hellwig , Hannes Reinecke , "James E.J. Bottomley" , , Subject: Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file Organization: D03 References: <20151004080217.GA22816@infradead.org> <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> <1444037200-14684-2-git-send-email-linux@rasmusvillemoes.dk> <56128398.8070908@sandisk.com> X-Hashcash: 1:20:151006:hch@infradead.org::hoibrAfHgZtkrk94:0000000000000000000000000000000000000000000015wb X-Hashcash: 1:20:151006:linux-kernel@vger.kernel.org::RAu6QA4CoEqDfiPb:00000000000000000000000000000000016Xe X-Hashcash: 1:20:151006:jbottomley@odin.com::kGfTnnHjxa/xUTzl:0000000000000000000000000000000000000000001/dE X-Hashcash: 1:20:151006:linux-scsi@vger.kernel.org::mtEucDmirN5UrtEf:000000000000000000000000000000000002P8r X-Hashcash: 1:20:151006:hare@suse.de::QRm0ytGvyhms0MMF:000008NjV X-Hashcash: 1:20:151006:bart.vanassche@sandisk.com::JcyYqzgIb+3Rh3Bw:0000000000000000000000000000000000082mv Date: Tue, 06 Oct 2015 17:27:57 +0200 In-Reply-To: <56128398.8070908@sandisk.com> (Bart Van Assche's message of "Mon, 5 Oct 2015 07:05:12 -0700") Message-ID: <87h9m4m2yq.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05 2015, Bart Van Assche wrote: > On 10/05/15 02:26, Rasmus Villemoes wrote: >> - {0x041A, "Logical unit not ready, start stop unit command in " >> - "progress"}, >> - {0x041B, "Logical unit not ready, sanitize in progress"}, >> - {0x041C, "Logical unit not ready, additional power use not yet " >> - "granted"}, > > Please convert these multi-line strings into single line string > constants such that users can look up these easily with grep. I can certainly do that, but I'd prefer to do it in a separate patch. I really want to keep this as mechanical as possible. >> + >> +SENSE_CODE(0, NULL) > > The above looks confusing to me. Please leave this out and add { 0, > NULL } at the end of the additional[] array instead. OK, I agree that that would have been cleaner. However, the sentinel entry is removed in 2/2 (since we loop using ARRAY_SIZE instead of checking for the sentinel). Let me know if you want me to resend the 1600 line monster anyway with this addressed. Thanks, Rasmus