From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754356AbbI3I4m (ORCPT ); Wed, 30 Sep 2015 04:56:42 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:35570 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbbI3I4i (ORCPT ); Wed, 30 Sep 2015 04:56:38 -0400 From: Rasmus Villemoes To: Andy Shevchenko Cc: Andrew Morton , Tejun Heo , linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH 4/4] test_printf: test printf family at runtime Organization: D03 References: <1443202865-25533-1-git-send-email-linux@rasmusvillemoes.dk> <1443202865-25533-5-git-send-email-linux@rasmusvillemoes.dk> <1443431579.8361.234.camel@linux.intel.com> <874miefemv.fsf@rasmusvillemoes.dk> <1443595086.8361.272.camel@linux.intel.com> X-Hashcash: 1:20:150930:tj@kernel.org::WmKwNRatT/BjoC2/:00000fn2 X-Hashcash: 1:20:150930:akpm@linux-foundation.org::HUIiMiKyn48j2dps:0000000000000000000000000000000000000dWQ X-Hashcash: 1:20:150930:keescook@chromium.org::YzjIFs0PEcX1i+1v:00000000000000000000000000000000000000001/tv X-Hashcash: 1:20:150930:linux-kernel@vger.kernel.org::MbxI/lq9A+OOiJrw:0000000000000000000000000000000003tnh X-Hashcash: 1:20:150930:andriy.shevchenko@linux.intel.com::ZWoMq+dKeMei43RI:00000000000000000000000000004529 Date: Wed, 30 Sep 2015 10:56:34 +0200 In-Reply-To: <1443595086.8361.272.camel@linux.intel.com> (Andy Shevchenko's message of "Wed, 30 Sep 2015 09:38:06 +0300") Message-ID: <87h9mcl1z1.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30 2015, Andy Shevchenko wrote: > It's still better to distinguish what function does by names > test vs. __test confuses me. Think of test() as the ordinary "public" interface and __test() as "private, but we expose it because you might need it, if you know what you're doing". Having two related functions named like this is a perfectly normal pattern in the kernel (even if one isn't necessarily implemented in terms of the other); examples are legio. krealloc/__krealloc (the latter is not called krealloc_nofree), fls/__fls (not fls_I_know_word_is_nonzero, thank $deity), ... >> >Maybe commentary delimiter here and above where you have double >> >empty line. >> >> And say what? I can avoid double empty lines if they bother you. > > So, what was the reason to add them in the first place? Just so we could have this interesting little chat. I don't think it was intentional, but don't worry, they're gone. >> > > +MODULE_AUTHOR("Rasmus Villemoes "); >> > > +MODULE_LICENSE("GPL"); >> > >> > GPL or ?.. >> >> Honestly, I don't really care. Would you like BSD/GPL or what? I just >> copied from the majority of MODULE_LICENSE() instances. > > You are the author, your choice. I'm okay with any applicable type. Then I'll stick to GPL, even if that's more cargo-culting than deliberate informed choice. Rasmus