From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903AbbHDG0R (ORCPT ); Tue, 4 Aug 2015 02:26:17 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:39136 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753463AbbHDG0Q (ORCPT ); Tue, 4 Aug 2015 02:26:16 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 04 Aug 2015 08:26:15 +0200 X-ME-IP: 109.214.23.104 From: Robert Jarzmik To: Stephen Boyd Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia Subject: Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access References: <1438631907-27993-1-git-send-email-robert.jarzmik@free.fr> <55C00A6B.2030508@codeaurora.org> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 04 Aug 2015 08:22:40 +0200 In-Reply-To: <55C00A6B.2030508@codeaurora.org> (Stephen Boyd's message of "Mon, 03 Aug 2015 17:42:19 -0700") Message-ID: <87h9ofmv2n.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Boyd writes: > On 08/03/2015 12:58 PM, Robert Jarzmik wrote: >> Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names >> were inadequately inverted. As a consequence, all clock operations were >> happening on CKENB, because almost all but 2 clocks are on CKENA. >> >> As the clocks were activated by the bootloader in the former tests, it >> escaped the testing that the wrong clock gate was manipulated. The error >> was revealed by changing the pxa3xx-and driver to a module, where tupon >> unloading the wrong clock was disabled in CKENB. >> >> Signed-off-by: Robert Jarzmik >> --- > > Did you want a fixes tag to send this back to stable? Ah yes, good point, v2 on its way. Stephen and Mike, do you think this can still get in -rc6 ? Cheers. -- Robert