From: Rusty Russell <rusty@rustcorp.com.au>
To: Eric Dumazet <eric.dumazet@gmail.com>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>, Robin Holt <holt@sgi.com>
Subject: Re: [PATCH] module: struct module_ref should contains long fields
Date: Mon, 19 Dec 2011 16:18:45 +1030 [thread overview]
Message-ID: <87hb0xnmbm.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1324053390.25554.50.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Fri, 16 Dec 2011 17:36:30 +0100, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le vendredi 16 décembre 2011 à 08:05 -0800, Tejun Heo a écrit :
> > Hello,
> >
> > On Fri, Dec 16, 2011 at 8:01 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > > Its percpu data, there is no need to waste a full cache line per cpu for
> > > this.
> >
> > Hmmm.... okay. I just don't like seeing arbitrary alignment there.
> > Can you please add some comment explaining why the unusual alignment
> > is used there?
>
> Yep, thanks for the review !
Thanks, applied!
Cheers,
Rusty.
prev parent reply other threads:[~2011-12-19 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 5:07 Eric Dumazet
2011-12-16 15:54 ` Tejun Heo
2011-12-16 16:01 ` Eric Dumazet
2011-12-16 16:05 ` Tejun Heo
2011-12-16 16:36 ` Eric Dumazet
2011-12-19 5:48 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb0xnmbm.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome