mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Marco Rogantini <marco.rogantini@supsi.ch>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: [PATCH] pcmcia: Add support TI PCI4510 CardBus bridge
Date: Mon, 07 Feb 2005 02:11:33 +0900	[thread overview]
Message-ID: <87hdkptxyy.fsf_-_@devron.myhome.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.62.0502061530550.24476@rost.dti.supsi.ch> (Marco Rogantini's message of "Sun, 6 Feb 2005 15:38:30 +0100 (CET)")

Marco Rogantini <marco.rogantini@supsi.ch> writes:

>> +#define PCI_DEVICE_ID_TI_4510		0xac44
>> +	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4510, TI12XX),
>
> :-) It solved the problem! However I still must use the 'disable_clkrun'
> parameter to get the bridge working correctly.

Great! Thanks. I checked the datasheet, and added zoom_video
support. New patch is attached.

Andrew, could you apply this patch to your tree for testing?
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>



This does setup PCI4510 properly, and supports the "disable_clkrun" option.

1) Add PCI_DEVICE_ID_TI_4510 to pci_id.h.
2) Add PCI4510 to yenta_table (that uses TI12XX handlers).
3) Add zoom_video handler support.

TI12XX handlers can disable CLKRUN feature with "disable_clkrun" option.
Some devices or bridge itself seems to be needing this option as workaround.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---

 drivers/pcmcia/ti113x.h       |    1 +
 drivers/pcmcia/yenta_socket.c |    1 +
 include/linux/pci_ids.h       |    1 +
 3 files changed, 3 insertions(+)

diff -puN drivers/pcmcia/ti113x.h~yenta-pci4510-support drivers/pcmcia/ti113x.h
--- linux-2.6.11-rc3/drivers/pcmcia/ti113x.h~yenta-pci4510-support	2005-02-07 01:46:12.000000000 +0900
+++ linux-2.6.11-rc3-hirofumi/drivers/pcmcia/ti113x.h	2005-02-07 01:46:12.000000000 +0900
@@ -262,6 +262,7 @@ static void ti_set_zv(struct yenta_socke
 			case PCI_DEVICE_ID_TI_1220:
 			case PCI_DEVICE_ID_TI_1221:
 			case PCI_DEVICE_ID_TI_1225:
+			case PCI_DEVICE_ID_TI_4510:
 				socket->socket.zoom_video = ti_zoom_video;
 				break;	
 			case PCI_DEVICE_ID_TI_1250:
diff -puN drivers/pcmcia/yenta_socket.c~yenta-pci4510-support drivers/pcmcia/yenta_socket.c
--- linux-2.6.11-rc3/drivers/pcmcia/yenta_socket.c~yenta-pci4510-support	2005-02-07 01:46:12.000000000 +0900
+++ linux-2.6.11-rc3-hirofumi/drivers/pcmcia/yenta_socket.c	2005-02-07 01:46:12.000000000 +0900
@@ -1105,6 +1105,7 @@ static struct pci_device_id yenta_table 
 	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4410, TI12XX),
 	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4450, TI12XX),
 	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4451, TI12XX),
+	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4510, TI12XX),
 	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_4520, TI12XX),
 
 	CB_ID(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_1250, TI1250),
diff -puN include/linux/pci_ids.h~yenta-pci4510-support include/linux/pci_ids.h
--- linux-2.6.11-rc3/include/linux/pci_ids.h~yenta-pci4510-support	2005-02-07 01:46:12.000000000 +0900
+++ linux-2.6.11-rc3-hirofumi/include/linux/pci_ids.h	2005-02-07 01:46:12.000000000 +0900
@@ -753,6 +753,7 @@
 #define PCI_DEVICE_ID_TI_1251B		0xac1f
 #define PCI_DEVICE_ID_TI_4410		0xac41
 #define PCI_DEVICE_ID_TI_4451		0xac42
+#define PCI_DEVICE_ID_TI_4510		0xac44
 #define PCI_DEVICE_ID_TI_4520		0xac46
 #define PCI_DEVICE_ID_TI_1410		0xac50
 #define PCI_DEVICE_ID_TI_1420		0xac51
_

      reply	other threads:[~2005-02-06 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-05 17:29 rtl8139 (8139too) net problem in linux 2.6.10 Marco Rogantini
2005-02-05 19:03 ` OGAWA Hirofumi
2005-02-05 20:03   ` Marco Rogantini
2005-02-05 21:24     ` OGAWA Hirofumi
2005-02-05 21:33       ` OGAWA Hirofumi
2005-02-06 14:38         ` Marco Rogantini
2005-02-06 17:11           ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hdkptxyy.fsf_-_@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.rogantini@supsi.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®