Re: [2.6.10-rc2-mm1] OOPS on boot (hotplug related?)

[Mathieu Segaud <matt@minas-morgul.org>]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Andrew Morton <akpm@osdl.org> disait dernièrement que :

> Christian Axelsson <smiler@lanil.mine.nu> wrote:
>>
>> I'm getting OOPSes on boot on my laptop. Output is copied by hand and Ive 
>> only included the parts that I *think* are useful:
>> 
>> ...
>> EIP is at get_nonexclusive_access+0x13/0x40
>
> Yup, seems that reiser4 broke.  I've forwarded a copy of an earlier report
> to reiserfs-dev@namesys.com.

V. Saveliev provided the right fix shortly after I reported this oops.

I attach the patch

Regards,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: reiser4-context-fix.patch --]
[-- Type: text/x-patch, Size: 994 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/11/15 16:23:47+03:00 vs@tribesman.namesys.com 
#   unix_file_filemap_nopage: missing context creation is added
# 
# plugin/file/file.c
#   2004/11/15 16:23:45+03:00 vs@tribesman.namesys.com +5 -1
#   unix_file_filemap_nopage: missing context creation is added
# 
diff -Nru a/plugin/file/file.c b/plugin/file/file.c
--- a/plugin/file/file.c	2004-11-17 09:36:11 +03:00
+++ b/plugin/file/file.c	2004-11-17 09:36:11 +03:00
@@ -1961,8 +1961,10 @@
 {
 	struct page *page;
 	struct inode *inode;
-
+	reiser4_context ctx;
+	
 	inode = area->vm_file->f_dentry->d_inode;
+	init_context(&ctx, inode->i_sb);
 
 	/* block filemap_nopage if copy on capture is processing with a node of this file */
 	down_read(&reiser4_inode_data(inode)->coc_sem);
@@ -1972,6 +1974,8 @@
 
 	drop_nonexclusive_access(unix_file_inode_data(inode));
 	up_read(&reiser4_inode_data(inode)->coc_sem);
+
+	reiser4_exit_context(&ctx);
 	return page;
 }
 

[-- Attachment #3: Type: text/plain, Size: 131 bytes --]



-- 
Lisa R. Nelson wrote:
> So much for a friendly group.

You really have seen nothing yet :-)

	- Bas Mevissen on linux-kernel