Re: [PATCH] ALSA: hda/realtek: Fix speaker and mic mute LEDs on IdeaPad Pro 5 14IAH10

[Takashi Iwai <tiwai@suse.de>]

On Tue, 13 Oct 2026 20:37:42 +0200,
Aayush Kumar wrote:
> 
> The speaker and microphone mute LEDs on the IdeaPad Pro 5 14IAH10
> do not follow the ALSA mute state. This machine has an ALC287 codec
> with SSID 17aa:3914, but shares PCI SSID 17aa:3843 with the Yoga
> Book 9i and currently gets its fixup.
> 
> Add a codec SSID quirk that runs the IdeaPad ACPI LED fixup. Chain
> the existing bass speaker amp fixup so the audio setup is retained.
> 
> Tested on the IdeaPad Pro 5 14IAH10: muting and unmuting the
> headphone sink toggled the physical speaker mute LED. Muting both
> microphone controls changed the ALSA mic LED state from 0 to 1.
> 
> Signed-off-by: Aayush Kumar <aayushkmx@gmail.com>
> ---
>  sound/hda/codecs/realtek/alc269.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index be5482530..44652fc43 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -4285,6 +4285,7 @@ enum {
>  	ALC295_FIXUP_HP_OMEN,
>  	ALC285_FIXUP_HP_SPECTRE_X360,
>  	ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP,
> +	ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED,
>  	ALC623_FIXUP_LENOVO_THINKSTATION_P340,
>  	ALC255_FIXUP_ACER_HEADPHONE_AND_MIC,
>  	ALC236_FIXUP_HP_LIMIT_INT_MIC_BOOST,
> @@ -6435,6 +6436,12 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.chained = true,
>  		.chain_id = ALC285_FIXUP_THINKPAD_HEADSET_JACK,
>  	},
> +	[ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_ideapad_acpi,
> +		.chained = true,
> +		.chain_id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP,
> +	},
>  	[ALC287_FIXUP_LENOVO_YOGA_PRO7] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc_fixup_yoga_pro7_audio,
> @@ -8215,6 +8222,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x3827, "Ideapad S740", ALC285_FIXUP_IDEAPAD_S740_COEF),
>  	SND_PCI_QUIRK(0x17aa, 0x3834, "Lenovo IdeaPad Slim 9i 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
>  	SND_PCI_QUIRK(0x17aa, 0x383d, "Legion Y9000X 2019", ALC285_FIXUP_LEGION_Y9000X_SPEAKERS),
> +	HDA_CODEC_QUIRK(0x17aa, 0x3914, "Lenovo IdeaPad Pro 5 14IAH10",
> +			ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP_LED),
>  	SND_PCI_QUIRK(0x17aa, 0x3843, "Lenovo Yoga 9i / Yoga Book 9i", ALC287_FIXUP_LENOVO_YOGA_BOOK_9I),
>  	/* Yoga Pro 7 14IMH9 shares PCI SSID 17aa:3847 with Legion 7 16ACHG6;
>  	 * use codec SSID to distinguish them

Could you give a comment to mention shortly about the conflicting PCI
SSID?

Also, the patch doesn't apply cleanly on top of the latest sound git
tree.  Please try to rebase to for-next branch and resubmit.


thanks,

Takashi