From: Takashi Iwai <tiwai@suse.de>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jianhao Xu <jianhao.xu@seu.edu.cn>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: oxygen: use helper to activate the SPDIF PCM control
Date: Mon, 28 Sep 2026 14:26:00 +0200 [thread overview]
Message-ID: <87ik3p5zqf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260927121709.742840-1-runyu.xiao@seu.edu.cn>
On Sun, 27 Sep 2026 14:17:09 +0200,
Runyu Xiao wrote:
>
> oxygen_open() and oxygen_close() modify the SPDIF PCM control access
> flags while holding chip->mutex. Direct access changes bypass the control
> core locking and notification path.
>
> Move the access transition outside the driver mutex and use
> snd_ctl_activate_id(), which serializes the control update with the control
> core.
>
> Fixes: d0ce9946c52e ("[ALSA] add CMI8788 driver")
> Assisted-by: LLM
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-09-28 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 12:17 Runyu Xiao
2026-09-28 12:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik3p5zqf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=clemens@ladisch.de \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=runyu.xiao@seu.edu.cn \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®