From: Jonathan Corbet <corbet@lwn.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Michal Simek <michal.simek@amd.com>,
Ronak Jain <ronak.jain@amd.com>,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] firmware: zynqmp: use literal blocks for commands
Date: Tue, 15 Sep 2026 12:56:39 -0600 [thread overview]
Message-ID: <87ik469wd4.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260914060615.1398531-1-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> Use literal blocks for 'cat' and 'echo' commands to separate them from
> the surrounding text. Otherwise the lines run together, without any
> clear break before or after the commands.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Michal Simek <michal.simek@amd.com>
> Cc: Ronak Jain <ronak.jain@amd.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-doc@vger.kernel.org
>
> Documentation/ABI/stable/sysfs-driver-firmware-zynqmp | 70 +++++++---
> 1 file changed, 50 insertions(+), 20 deletions(-)
>
> --- linux-next-20260911.orig/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> +++ linux-next-20260911/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> @@ -141,32 +141,44 @@ Description:
>
> Usage:
>
> - Select over temperature config ID to enable/disable feature
> + Select over temperature config ID to enable/disable feature::
> +
> # echo 1 > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
I was sure that this wouldn't work, since the literal block is not
indented relative to the containing text. Sphinx does the right thing,
though... so applied, thanks,
jon
next prev parent reply other threads:[~2026-09-15 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 6:06 Randy Dunlap
2026-09-15 18:56 ` Jonathan Corbet [this message]
2026-09-15 19:06 ` Randy Dunlap
2026-09-15 19:50 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik469wd4.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=rdunlap@infradead.org \
--cc=ronak.jain@amd.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®