From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-106111.protonmail.ch (mail-106111.protonmail.ch [79.135.106.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCD43E4C99 for ; Thu, 27 Aug 2026 08:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787820397; cv=none; b=E6IVWSCe0o3w/bN2LK1cMidYtN2BOqAbhBoIpaL55S9a8VJWAX+fcr/Is82cirLzQrWTzza71wpo4tHfM/0ZTVkTCHZPwqbZIcuV1afKV2XSWzq5I2jlzTBjxIAHMvAwYRG7xpOHWYkN6bCsIZW8HGxgqTVdhr3R2TMvkGeYfQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787820397; c=relaxed/simple; bh=8ygZIPyqi2xZTWKQ5iqfRw4RZdkrrwtAfcDOoqwNYU0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JaTvdt3Io7yfPJifvGD3ekGiaOdBMx9A6r9pS4TDix/cwT1/kl/hlDHQbRaqmzblyQz+y/NcaVsL6qHNcT7Ms9MjkVnePptu6atQ1aICgjb+Yh24YTQvi/efNgTo1ZFF24Fc5Np/5ZFb8qGQ8t8cph33uqhv+b0FmjfdnVkz50A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com; spf=pass smtp.mailfrom=geanix.com; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b=fxufw8H0; arc=none smtp.client-ip=79.135.106.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=geanix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=geanix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="fxufw8H0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geanix.com; s=protonmail; t=1787820387; x=1788079587; bh=lhxuzSSCiA9yo+vWB5G26kPpXv6+d3Y2XXAaEPMMCxs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:From:To: Cc:Date:Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=fxufw8H0rYVX0gljTC5cW7Dhns3IVfsPfCCEX1pNfUN5a1WWscThCRevNWLM+blBu 2Y7742Ge+XrsVrn+G1pej7VUnDqTSK1o2blfkGefEnFIzA2Fnfb+ggkxb6+ehs5rYm b7FiXHXj3p25EI4kHmzNuuU2DnvhDH1K0zjzXSIPHuuHu72pgTaM5VSO45b40jwB+4 h6g6YaGVA9de+tlnbIHT1aLQSL4mwGLHJmJ9Dd/4iJoSFJME/mlioSrA71of3NfjOn RGpvgf6aG+QUU4ZhreRtk6M+Ebdwlzo7icT6MsTj/gcSPtJEZWrNanj48OfaxFbEVJ WPM/frx12sBuA== X-Pm-Submission-Id: 4hVw9F285Pz1DFFg From: Esben Haabendal To: "Rosen Penev" Cc: , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Michal Simek" , , Subject: Re: [PATCH net] net: ll_temac: Return actual error from of_get_mac_address() In-Reply-To: <20260827012439.162651-1-rosenp@gmail.com> (Rosen Penev's message of "Wed, 26 Aug 2026 18:24:39 -0700") References: <20260827012439.162651-1-rosenp@gmail.com> Date: Thu, 27 Aug 2026 10:46:24 +0200 Message-ID: <87ik4wymqn.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Rosen Penev" writes: > When of_get_mac_address() fails, return the actual error code (rc) > instead of the hardcoded -ENODEV. This preserves the original error > information, which may be more specific (e.g., -EINVAL, -EPROBE_DEFER) > and helps callers handle the failure appropriately. > > Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms") > Assisted-by: opencode:big-pickle > Signed-off-by: Rosen Penev > --- > drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 711ed9c2631b..81ec73e6e4c1 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1581,7 +1581,7 @@ static int temac_probe(struct platform_device *pdev) > rc = of_get_mac_address(temac_np, addr); > if (rc) { > dev_err(&pdev->dev, "could not find MAC address\n"); > - return -ENODEV; > + return rc; > } > temac_init_mac_address(ndev, addr); > } else if (pdata) { > -- > 2.55.0 Acked-by: Esben Haabendal