From: John Ogness <john.ogness@linutronix.de>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Thomas Gleixner <tglx@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: Don't WARN on kthread_run failure.
Date: Thu, 20 Aug 2026 11:58:32 +0206 [thread overview]
Message-ID: <87ik559l0f.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <76bb4c1c-5d85-4635-b3bb-fc06f292c59e@I-love.SAKURA.ne.jp>
On 2026-08-04, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
> Since __kthread_create_on_node() returns -EINTR upon SIGKILL,
> we should not use WARN_ON() in order to catch kthread_run() failure.
For historical context, the WARN_ON() was suggested here [0].
But since a kthread_run() failure also prints a dedicated failure
message, the WARN_ON is overkill.
> Reported-by: syzbot+1ebbc20f223b99446034@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1ebbc20f223b99446034
> Fixes: 5f53ca3ff83b ("printk: Implement legacy printer kthread for PREEMPT_RT")
> Fixes: 76f258bf3f2a ("printk: nbcon: Introduce printer kthreads")
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
[0] https://lore.kernel.org/lkml/87ed95j8yh.fsf@jogness.linutronix.de
next prev parent reply other threads:[~2026-08-20 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:52 Tetsuo Handa
2026-08-20 9:52 ` John Ogness [this message]
2026-08-20 13:17 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik559l0f.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®