From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB8B3E2AD3 for ; Fri, 26 Jun 2026 17:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782494424; cv=none; b=vD8KtEMd7eUZ9HrDGQwBypfzD07i+ge2d8V9+DA7847ItHlBY5Douq3c+8x/6XZJ3i6+jagIGNO+FZeer/e4AbqWCYbBzjirykVHUmGBNRQJG6teClA4UbBT18YvzG4zBj3xWR7jc9f1A0DjM28EJh3M5bUHLBCcN+ZsQ5JtYJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782494424; c=relaxed/simple; bh=5Z85LN1lrKrP9cbmR8jvLLPVYe6RzUjdudL9gz1dnSI=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=I7M6Wj6iO79caziqoJGAoX1VE/vftlQ4W8MJmG2xrvhgk0/87rd7HRwWT/wALq8bQri7lGaEyLq8r8eaF8BFONjsjr9uNDnDoozhdESz+Dl8X5KV3Ldu29xQnE6MtezIlz+V1wSI9mMpYEJDlJgstsEittiRV1ZmVPSE/KEjtEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=TBwSorvm; arc=none smtp.client-ip=166.70.13.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="TBwSorvm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5Z85LN1lrKrP9cbmR8jvLLPVYe6RzUjdudL9gz1dnSI=; b=TBwSorvmrZP0S9+q0Nzgjkl2o4 xnYnDPOmlxk2aR5iD5hkEmCOaBvgcUiwdjKTMTcUJOykwfHpDmrTKZE0VfByzhaOY988QRVmm6M7s 5uVb4kaFeuflAF01nEJqUvrs8S57I0rhMH+x0wn85XTDkR0HCd43wlcuVbUUbjLM2U8M=; Received: from in02.mta.xmission.com ([166.70.13.52]:41172) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wd9oh-008ieF-2V; Fri, 26 Jun 2026 10:54:11 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:52046 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wd9og-0040mi-8W; Fri, 26 Jun 2026 10:54:10 -0600 From: "Eric W. Biederman" To: Andrew Morton Cc: Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Oleg Nesterov In-Reply-To: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Fri, 26 Jun 2026 11:52:43 -0500") References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> Date: Fri, 26 Jun 2026 11:54:04 -0500 Message-ID: <87ik759r9v.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wd9og-0040mi-8W;;;mid=<87ik759r9v.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX1/wVpWjmBuh4ke/MsP9GJJSOFsovvJ0BvA= X-Spam-Level: X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4982] * 1.5 XMNoVowels Alpha-numberic number with no vowels * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Andrew Morton X-Spam-Relay-Country: X-Spam-Timing: total 395 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 4.4 (1.1%), b_tie_ro: 3.0 (0.8%), parse: 1.01 (0.3%), extract_message_metadata: 3.6 (0.9%), get_uri_detail_list: 1.51 (0.4%), tests_pri_-2000: 3.4 (0.9%), tests_pri_-1000: 2.2 (0.6%), tests_pri_-950: 1.23 (0.3%), tests_pri_-900: 0.92 (0.2%), tests_pri_-90: 69 (17.5%), check_bayes: 68 (17.2%), b_tokenize: 6 (1.6%), b_tok_get_all: 5 (1.3%), b_comp_prob: 1.29 (0.3%), b_tok_touch_all: 52 (13.3%), b_finish: 0.72 (0.2%), tests_pri_0: 293 (74.2%), check_dkim_signature: 0.45 (0.1%), check_dkim_adsp: 2.6 (0.7%), poll_dns_idle: 1.15 (0.3%), tests_pri_10: 1.73 (0.4%), tests_pri_500: 6 (1.6%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 01/11] signal: Compute the exit_code in get_signal X-SA-Exim-Connect-IP: 166.70.13.52 X-SA-Exim-Rcpt-To: oleg@redhat.com, linux-kernel@vger.kernel.org, wad@chromium.org, tglx@kernel.org, peterz@infradead.org, kusaram@devineni.in, kees@kernel.org, luto@kernel.org, akpm@linux-foundation.org X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out02.mta.xmission.com); SAEximRunCond expanded to false Update get_signal so it calls do_group_exit with the correct exit_code. Make the default exit_code 0, so that the special case for threads killed by de_thread falls out naturally. Update do_group_exit to trust the exit_code passed in except when SIGNAL_GROUP_EXIT is set. Moving the computation of exit_code into get_signal makes other cleanups possible. --- kernel/exit.c | 4 ++-- kernel/signal.c | 12 ++++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/kernel/exit.c b/kernel/exit.c index f50d73c272d6..ae143be7c831 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1098,7 +1098,7 @@ do_group_exit(int exit_code) if (sig->flags & SIGNAL_GROUP_EXIT) exit_code = sig->group_exit_code; else if (sig->group_exec_task) - exit_code = 0; + ; else { struct sighand_struct *const sighand = current->sighand; @@ -1107,7 +1107,7 @@ do_group_exit(int exit_code) /* Another thread got here before we took the lock. */ exit_code = sig->group_exit_code; else if (sig->group_exec_task) - exit_code = 0; + ; else { sig->group_exit_code = exit_code; sig->flags = SIGNAL_GROUP_EXIT; diff --git a/kernel/signal.c b/kernel/signal.c index 9c2b32c4d755..39fbf9c9474a 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2865,10 +2865,13 @@ bool get_signal(struct ksignal *ksig) for (;;) { struct k_sigaction *ka; enum pid_type type; + int exit_code = 0; /* Has this task already been marked for death? */ if ((signal->flags & SIGNAL_GROUP_EXIT) || signal->group_exec_task) { + if (signal->flags & SIGNAL_GROUP_EXIT) + exit_code = signal->group_exit_code; signr = SIGKILL; sigdelset(¤t->pending.signal, SIGKILL); trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, @@ -2998,14 +3001,15 @@ bool get_signal(struct ksignal *ksig) continue; } + /* + * Anything else is fatal, maybe with a core dump. + */ + exit_code = signr; fatal: spin_unlock_irq(&sighand->siglock); if (unlikely(cgroup_task_frozen(current))) cgroup_leave_frozen(true); - /* - * Anything else is fatal, maybe with a core dump. - */ current->flags |= PF_SIGNALED; if (sig_kernel_coredump(signr)) { @@ -3035,7 +3039,7 @@ bool get_signal(struct ksignal *ksig) /* * Death signals, no core dump. */ - do_group_exit(signr); + do_group_exit(exit_code); /* NOTREACHED */ } spin_unlock_irq(&sighand->siglock); -- 2.41.0