From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2238317176 for ; Mon, 18 May 2026 09:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779098138; cv=none; b=pnS3ztF13TOGD+ylgf1m/KfUj8VygMHG0aRLzpkBKOMIVnPurj7a+kB7BnRa8/lKw/YVBQPavztoc7PKqH4xxyQ9q1odsCpDRadf/iOu/CL99JuCpq89lfJgTmnsNHq7jSIOkJ8+LkSHnNKEHhEDmCYUS5/UlCH4QU0LCHG5khU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779098138; c=relaxed/simple; bh=ZBhj2Q6rqsIeG71DxmrjLD034wo9u2IYHUiX5foSzKs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=fyeIKuqAptpAGqvytD/zB4pkE8vVBboUSnu83ElaLwrO3swzpQtpNg0GdXtMt2DrbXSQv4bCqPjrRehnp/7aGm8zWOMU/Ezs2T938GJp4PAbYYw36JWEbS9dUtAvyft1juLCWvUBE2bXtaG4CPAt8+FY8P8C7/og7caHtfLzwQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cPAMh194; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aFkYWu4E; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cPAMh194"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aFkYWu4E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779098136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xudk4GOO+l3lmPzk8MU5bwUvZOAX00ItJJurhMyKKiw=; b=cPAMh194UlSAkwbKgJQf3Tp4w2ptY85v8kFiQI0bOHxvJa82/l7MNlTd15dzCIYqRZM4Pf op4O4RFtembmb4mZFL3N6CJ2op1dVhL0BloifEtimqQ26IZoRoi5IEXS9XxUcO3wqSZ7AC rVyvBNo+GpEHKWVvirovVsahVkuoLoU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-PPoHxXweMCGd2at_mvxCEA-1; Mon, 18 May 2026 05:55:34 -0400 X-MC-Unique: PPoHxXweMCGd2at_mvxCEA-1 X-Mimecast-MFC-AGG-ID: PPoHxXweMCGd2at_mvxCEA_1779098133 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4411a36715dso1333253f8f.2 for ; Mon, 18 May 2026 02:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779098133; x=1779702933; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=xudk4GOO+l3lmPzk8MU5bwUvZOAX00ItJJurhMyKKiw=; b=aFkYWu4EZktjRMUaaRgXB1Flv7hiOfraQwvoNtk4OfakyLT+0w4EdnbadfCf3lF0MF dpUMHHyl+RqLcw1P+Fmt+uiPB/MISz9kIHygRay0WwYTyLa/4O4IAz3kG0aIol6cP3E3 Z7QZkSFcDYVqKi4BdniyMR7KGwK91j78Ftq/MzYs2S5d+cAmU0naZv/+69h0IdW5djGJ neGw/DEi2v0OMv81nmDwIFaVrepypHnNhD5eW8VF3aVzM9D4shf+ErjqvjVyeKtuHtTJ Cv301q3oN5X/wGkMoCYnyIBvv4HIoqURBuvS5zNyhGe8Opv5BU2Wjbk92B3Pm8ExGAXp jRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779098133; x=1779702933; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xudk4GOO+l3lmPzk8MU5bwUvZOAX00ItJJurhMyKKiw=; b=Qlx6ZBKZbniu4+pT5RElmHHzEPPl0xO56VGJagfRIsLSalzl7UEL0KfbKxnJTsfSVx BHOJIe3JH0wvyGD6sjsIJobzVG4ZBCC7qiWUPVq7cJE7WpqaI6VdJyfw91+t88LVccCg V5Z2wIuAiCHtdTf1BlCSvtZAD5+kcFyix0XY3013hayJrXuo9O4Bfm5pzwumfPth5uC5 N7rpOtgo8jx7OphG5d9j8MNlA/Tnn7lmHRkg/w1owKt77/P+sESaZmpAnowP+rqOSPrF w57Mp15uAFHUY0D9NES8WExeBcRmmXl++mXpifRRzhcFy1K+fgykJOKGH3AuzkvFcCRP HMVA== X-Forwarded-Encrypted: i=1; AFNElJ9kQ11HccZnOx04omPbNm9N1A43yNVe75m5akKL3zlfaExgwbInt8Govl5idxlUSn4/KWTIRtC34cdUkeA=@vger.kernel.org X-Gm-Message-State: AOJu0YxrC7X3bovYHZPRZ7B3xl61NRHQnfDJwbHeONxJNHuyYwNXJZ9j zc04F1yZPFndow4zv7pG1n+prVua8Xyn5lFt64TCDrLWraZMqbSeBVJ0T9+7K1Bcp07oIisvJrF U5dxK9049V7Dsp/j+t90ebv3gj2yath1LR3KJCdS9hp16xnumh4L6eOfwbIfEOYLByw== X-Gm-Gg: Acq92OHpA5DRWGX9DU8VNc1jn0Rq+C+t8Jy/yS3v6YMkFfWClghzUJGmOvYeKtW3lCF lj4iWNUrVWxVSgJP6tetveDUEQUaXulpN6peDohCCxPP2jeCQKbSIV/gJj0oUh7xFZPjyPTBS9C 5Vw9izDFAkm0CJipXNfBX9Ww645RrMGTZK1Cxk+3w3bFewxVavR4UaUyqNSw1m0wiZEeYDzHQms EGi0HgWJBJcq+GtRNSIQETjjq4TCgQEp88N9ExVraueXX5wPqb6QSAKlgOMqTXNRJg8IYuaZotO hzxzd+OAcyOjMZqibQQwyY0BicJ8BxeSatK+e1lsk47I5KR0LMQJS5jIkmyBcloLw7J6J5hGI6d /a9Q/XSGlDdOlLwIPK83c/7l9audPA/+derjZTb3N9iuISZVMy78pBbovwVen8TnCerMeSMbwSF IXYJkm X-Received: by 2002:a05:6000:230d:b0:446:96b1:f5f with SMTP id ffacd0b85a97d-45e5c35da70mr19965369f8f.8.1779098133051; Mon, 18 May 2026 02:55:33 -0700 (PDT) X-Received: by 2002:a05:6000:230d:b0:446:96b1:f5f with SMTP id ffacd0b85a97d-45e5c35da70mr19965330f8f.8.1779098132650; Mon, 18 May 2026 02:55:32 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec39806sm35212353f8f.9.2026.05.18.02.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:55:32 -0700 (PDT) From: Javier Martinez Canillas To: Julien Chauveau , Phong LE , Neil Armstrong , dri-devel@lists.freedesktop.org Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Julien Chauveau Subject: Re: [PATCH] drm/bridge: it66121: acquire reset GPIO in probe In-Reply-To: <87lddhxebe.fsf@ocarina.mail-host-address-is-not-set> References: <20260324193011.16583-1-chauveau.julien@gmail.com> <87lddhxebe.fsf@ocarina.mail-host-address-is-not-set> Date: Mon, 18 May 2026 11:55:31 +0200 Message-ID: <87ik8lxcrw.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Javier Martinez Canillas writes: > Julien Chauveau writes: > > Hello Julien, > >> The it66121_ctx structure has a gpio_reset field, and it66121_hw_reset() >> calls gpiod_set_value() on it. However, the GPIO descriptor is never >> acquired via devm_gpiod_get(), leaving gpio_reset as NULL throughout >> the driver lifetime. >> >> gpiod_set_value() silently returns when passed a NULL descriptor, so >> the hardware reset sequence in it66121_hw_reset() is a no-op. This >> leaves the chip in an undefined state at probe time, which can prevent >> it from responding on the I2C bus. >> >> The DT binding marks reset-gpios as a required property, so all >> compliant device trees provide this GPIO. Add the missing >> devm_gpiod_get() call after enabling power supplies and before the >> hardware reset, so the chip is properly reset with power applied. >> >> Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") >> Cc: stable@vger.kernel.org >> Signed-off-by: Julien Chauveau >> --- > > The patch looks good to me. I've also tested it on my BeaglePlay board. > > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Pushed to drm-misc (drm-misc-fixes). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat