From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2114A230BEC for ; Mon, 16 Feb 2026 07:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771228074; cv=none; b=izDg8qlymOlgcPIaZFAvNp8kkUhOlxqRufTJKG3JeGG6O3ys0p03TA7E3WLLp87W0Q8womBG8UvKPeI5SV2+UZDnlLSeMEwI1IJQHbBkKm//0lI4wb/dx5tvLwah/ly7zftwdxVoEK+Uefphv3rOjP8ozO1vf212clx04ypNi34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771228074; c=relaxed/simple; bh=IoFIGzQimZLbVRh5noEa3tS+7xfSJD4SybpBAwr68Kw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=F+oIHAZSQvUpXVcKaXNH/COPLcCpgLwIY14xkVG/iOP6U894PhAM3pet+P57uxIaCyrs7EfyGvJe7149kZmQ3pZPdpWNZ+W5s442pwKPHhof02042RIJu8mfsokaho1uyn3HuqThVdbt5okpxuY+ZZsaly+Okbp0fsAzef/h1gw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UOfWtqPO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zt5QN6hS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UOfWtqPO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zt5QN6hS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771228072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uol2fLV3qDx0A8pdj/OSTFONpzYOz9GPk6lW8EILWMI=; b=UOfWtqPOf/t3VFOTpePLxxARwO08Nbp73a/KdBDQ7RtgzlqbHybkF+YpXNqvW+wW/QFsDz i3HD9nZHK4qNeUNTzLkx1sZGK3FkuPXf7WndWOa3PdtDYaNQgKIGEr/o1rDUtNOXxoiO0a M9yXOi/ce5svcEV9Ce2UfnRFHcf5Xhg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-YU-z0U62NVqwJDpOJBjVjg-1; Mon, 16 Feb 2026 02:47:50 -0500 X-MC-Unique: YU-z0U62NVqwJDpOJBjVjg-1 X-Mimecast-MFC-AGG-ID: YU-z0U62NVqwJDpOJBjVjg_1771228070 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4806cfffca6so36075005e9.2 for ; Sun, 15 Feb 2026 23:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771228069; x=1771832869; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uol2fLV3qDx0A8pdj/OSTFONpzYOz9GPk6lW8EILWMI=; b=Zt5QN6hSineMCaUDp2ADnfK9ZewjhUGHFb2MqF007Vv2+j4aXDJcNbgvT2uBQpTjVO Kqobk1WYtVqI5ZXwYreq/ypDdX2c5NXRbe3ATZfu2YwFC3pauskyyvpX8TIYTzM0CV+d sUtn676OhLsjmAccJj125Bd1hQ+rmQEuRezydzEojB2KaagTvDxVavCucJvr0+X2YstT 66aw6PUV5T1MoJcjSYySepqcTPBerJRY/RpjXXfNi+Nn+uyq8VrZwg2ZpYeKY1Au37vh IGD2vC6FR0IjuuyoDCeeM6GUVxC8EHkkWtAXuyjwJSqWa/NUYZss50FHKUX08A/FUKqR U83g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771228069; x=1771832869; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uol2fLV3qDx0A8pdj/OSTFONpzYOz9GPk6lW8EILWMI=; b=Jv7B3ToHluRWd+ZnqonREHh94nimSb8/W3kcMaPnTZ0URetVS5Uj1PiOwFnWPvHoPE 2tYIRVzeYJAkvRoE/kbcf8GOu2PkEM4lIWZu8EVXBwYb/j2Zb/RjrgqQA7bgZy9aI3ah FTJaqkYeaR4fCRsjB4XAewTG2k1/C+dJVnpLN76/wB5sHgUQSmIbkJeNWaOMaefpuxBt xUNdAl5jjss+ef2QOAY9MCsfHDIAfC+Ynez9gbfxM1RGw3wGbk+kzn7kmKXWRWrG0Guw 4czjXHt3NzWTogrcukK+rxWJy0Nm6uYxoo71ppCDJtcJjGGdgHjou2IHPDUDji/DO5Dl uAaw== X-Forwarded-Encrypted: i=1; AJvYcCXM4VW2z4y2Dp0lMDRzLAjLKALB21Km59UD77Kql5rz+t+AQ2j/KYG/3SXDPmQJFnzn0Gc9Z4vNylo1t+4=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ4MdaxXLv/ksUOUM98KKzgPSwJFpJs9EfvDpqlLXaEAV9J+/H AGoBLPejK9UvLkfHybMjntOt3UAWhJDxpKI/ffyniSXbZ+QBEYZ2CrhnDN4lEXe9VvpkuV8LwiO cKIc69diJ8fzKqn6HT11VolLOZ+pLyUGvwRnpcrTSCyh/gpb/W7LSoxKunUdL6FxACw== X-Gm-Gg: AZuq6aKGbg2cnyJmX1zOe2Bdbzp5MVimkTa6ifKuQaAf4/KILerQMzPlbmUXlunM9JM uhxMUQIN8sFcyF5NiO/5aeo0dCfbJD1P0W8pqj+Zs+ugWDSUUVqeYFLzErLm/uBB/kRtpz+AZCs Lb3w4qFp6nHEAz4QLvx/0BBqJKqz5RumNNxrZsC6p1d+bQOjiEDXCyQnlg6cYUecnWOpMlH8AIM g3z+A6esenDzskSaB8JlZ3YWaWzPJ/3PPI9JQycaO3EujDQCa9KJM2ov2sMJQu9vpIEf6crS7/T IU7gSibhTi0lb6WTorxNErkizB4pPtvRp+6l5u70G3loRMZSsatVnSJSp51xkgBwUBEk3XFcY+s or8XXwXIBV+YbP8/l3zW7/wU0on54JKFibjVDdCvFv904i+c5kbJnifj3aFOLPv7K29lE8+Pr44 2nHQHr X-Received: by 2002:a05:600c:450a:b0:46e:35a0:3587 with SMTP id 5b1f17b1804b1-48373a4e82emr158832275e9.27.1771228068796; Sun, 15 Feb 2026 23:47:48 -0800 (PST) X-Received: by 2002:a05:600c:450a:b0:46e:35a0:3587 with SMTP id 5b1f17b1804b1-48373a4e82emr158831945e9.27.1771228068384; Sun, 15 Feb 2026 23:47:48 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d5ebd34sm469831235e9.7.2026.02.15.23.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 23:47:47 -0800 (PST) From: Javier Martinez Canillas To: Archit Anant , wens@kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, nathan@kernel.org, geert+renesas@glider.be, marcus.folkesson@gmail.com, david@lechnology.com, noralf@tronnes.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] drm/sitronix: add ST7789V panel driver In-Reply-To: References: <20260214070123.41374-1-architanant5@gmail.com> Date: Mon, 16 Feb 2026 08:47:46 +0100 Message-ID: <87ikbx6sf1.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Archit Anant writes: Hello Archit, > Hi ChenYu, > > Thank you for the detailed review and the pointers toward the documentation. > I will ensure the headers are sorted alphabetically and the driver name > conflict is resolved in the next iteration. > >> The reset logic in mipi_dbi is inverted when compared to panel-st7789v. >> mipi_dbi needs to be taught the "proper" reset polarity. > > Noted. I will look into the mipi_dbi core to see how to handle the reset > polarity correctly. > >> Instead this functionality could be merged into the existing panel-st7789v >> driver. You mentioned above that that driver only supports the 9-bit SPI >> transfer mode. However porting that driver over to mipi_dbi would fix this, >> and remove some redundant code. And tinydrm support could be added on top >> of that. >> >> I actually mentioned I was going to work on this on IRC. But I only ported >> the driver over to use mipi_dbi, and haven't gotten around to adding >> tinydrm support. I can send out the conversion patches if that helps >> you. > > That would be fantastic and would save a lot of redundant effort. If you > send out the patches to convert the existing panel-st7789v driver to > mipi_dbi, I would be happy to build the 'tiny' (simple display pipe) > support on top of your series. > I think we want to get rid of the simple display pipeline and instead just use regulator atomic helpers, even for the tiny DRM drivers. Please take a look to previous commits such as 2037174993c8 ("drm/bochs: Use regular atomic helpers") or 622113b9f11f ("drm/ssd130x: Replace simple display helpers with the atomic helpers"). -- Best regards, Javier Martinez Canillas Core Platforms Red Hat