From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-clk@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 4/4] arm64: dts: agilex5: initial support for Arrow AXE5-Eagle
Date: Tue, 19 Nov 2024 08:26:13 +0100 [thread overview]
Message-ID: <87iksj7kh6.fsf@pengutronix.de> (raw)
In-Reply-To: <3f55a225-7d09-486a-818f-307c1f1ba806@lunn.ch> (Andrew Lunn's message of "Wed, 30 Oct 2024 14:41:21 +0100")
On 2024-10-30 at 14:41 +01, Andrew Lunn <andrew@lunn.ch> wrote:
> > +&gmac2 {
> > + status = "okay";
> > + phy-mode = "rgmii-id";
> > + phy-handle = <&emac2_phy0>;
> > +
> > + max-frame-size = <9000>;
> > +
> > + mdio0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "snps,dwmac-mdio";
> > + emac2_phy0: ethernet-phy@1 {
> > + reg = <0x1>;
> > + adi,rx-internal-delay-ps = <2000>;
> > + adi,tx-internal-delay-ps = <2000>;
>
> You have rgmii-id and 2000ps delay? Are these two lines actually
> required?
The binding states that these lines are for rgmii-id (and rgmii-rxid) mode, so why not?
Or am I misunderstanding and you mean setting the default values here is unnecessary?
Best regards,
Steffen
--
Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-11-19 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:10 [PATCH 0/4] ARM64: dts: intel: agilex5: add nodes and new board Steffen Trumtrar
2024-10-30 12:10 ` [PATCH 1/4] arm64: dts: agilex5: add gpio0 Steffen Trumtrar
2024-10-30 13:58 ` Krzysztof Kozlowski
2024-10-30 12:10 ` [PATCH 2/4] arm64: dts: agilex5: add gmac nodes Steffen Trumtrar
2024-10-30 12:10 ` [PATCH 3/4] dt-bindings: intel: add agilex5-based Arrow AXE5-Eagle Steffen Trumtrar
2024-10-30 13:58 ` Krzysztof Kozlowski
2024-10-30 12:10 ` [PATCH 4/4] arm64: dts: agilex5: initial support for " Steffen Trumtrar
2024-10-30 13:41 ` Andrew Lunn
2024-11-19 7:26 ` Steffen Trumtrar [this message]
2024-10-30 14:00 ` Krzysztof Kozlowski
2024-10-30 17:04 ` [PATCH 0/4] ARM64: dts: intel: agilex5: add nodes and new board Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iksj7kh6.fsf@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome