From: Jonathan Corbet <corbet@lwn.net>
To: xu.xin16@zte.com.cn, alexs@kernel.org, si.yanteng@linux.dev,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mudongliangabcd@gmail.com, seakeel@gmail.com
Cc: wang.yaxin@zte.com.cn, fan.yu9@zte.com.cn, xu.xin16@zte.com.cn,
he.peilin@zte.com.cn, tu.qiang35@zte.com.cn,
qiu.yutan@zte.com.cn, zhang.yunkai@zte.com.cn
Subject: Re: [PATCH linux-next v8 RESEND] Docs/zh_CN: Translate physical_memory.rst to Simplified Chinese
Date: Mon, 04 Nov 2024 12:27:25 -0700 [thread overview]
Message-ID: <87ikt294v6.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20241028135321916ZWK032bHhlbncjvmzDkZs@zte.com.cn>
OK, I have applied this patch. A couple of comments for future reference:
<xu.xin16@zte.com.cn> writes:
> From: Yaxin Wang <wang.yaxin@zte.com.cn>
>
> This patch translates the "physical_memory.rst" document into
> Simplified Chinese to improve accessibility for Chinese-speaking
> developers and users.
Our documentation requests that patch changelogs be phrased in the
imperative tense and avoid terms like "this patch". Some maintainers
are quite insistent about that; I'm not one of them, but it is better to
follow that guidance.
> The translation was done with attention to technical accuracy
> and readability, ensuring that the document remains informative
> and useful in its translated form.
This is not helpful in a changelog; if you have not paid such attention,
you should not be submitting the patch in the first place. Comments
like this can go after the "---" line if you really need to include
them.
> Update to commit 7332f9e45d2e("docs/mm: Physical Memory: Fix grammar")
...and this I don't understand at all; why do you need to reference that
patch here?
Thanks,
jon
next prev parent reply other threads:[~2024-11-04 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 5:53 xu.xin16
2024-11-04 19:27 ` Jonathan Corbet [this message]
2024-11-05 1:54 ` Yanteng Si
2024-11-05 14:47 ` Jonathan Corbet
2024-11-06 2:09 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikt294v6.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=alexs@kernel.org \
--cc=fan.yu9@zte.com.cn \
--cc=he.peilin@zte.com.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=qiu.yutan@zte.com.cn \
--cc=seakeel@gmail.com \
--cc=si.yanteng@linux.dev \
--cc=tu.qiang35@zte.com.cn \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®