From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAB7C001B0 for ; Tue, 8 Aug 2023 19:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234641AbjHHTq1 (ORCPT ); Tue, 8 Aug 2023 15:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232114AbjHHTp7 (ORCPT ); Tue, 8 Aug 2023 15:45:59 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1706D16AD7; Tue, 8 Aug 2023 09:49:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ECB2920312; Tue, 8 Aug 2023 06:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691475177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q3MK00CjNLL1ZfC7N82ZXn6nuzBSj9WikxOJJsXFTxE=; b=u/kVXQ5FVsYn7MZJ9wIBDd56TjoPXUGOCVloXV5y/fMdjLGy9XPhw+Baps0z87S9QSXjQe iQnYprmoLqI/vk29lirFO0Btc3Ghgiex8OvPVdfdtcOZCzj02W5HPCqEU275jHuVf/DlEe HtNJ/BlgevNI+zKARShyWpMiPwqTJp4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691475177; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q3MK00CjNLL1ZfC7N82ZXn6nuzBSj9WikxOJJsXFTxE=; b=taJEEMQZ6yC504W4FpkfK/uGxk8QYw9Aw5SkOR06WzsekQaMPRhPx942c7UdLNawT6gGhx ec7f12QLRBZgPQDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A90EA139D1; Tue, 8 Aug 2023 06:12:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8BVUKOnc0WT5PgAAMHmgww (envelope-from ); Tue, 08 Aug 2023 06:12:57 +0000 Date: Tue, 08 Aug 2023 08:12:57 +0200 Message-ID: <87il9qhxjq.wl-tiwai@suse.de> From: Takashi Iwai To: "Jarkko Sakkinen" Cc: "Takashi Iwai" , "Peter Huewe" , "Jason Gunthorpe" , , Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts for Lenovo Thinkpad E14 Gen 2 and 13s-IML In-Reply-To: References: <20230807140125.18486-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Aug 2023 21:14:20 +0200, Jarkko Sakkinen wrote: > > On Mon Aug 7, 2023 at 2:01 PM UTC, Takashi Iwai wrote: > > Like other Lenovo laptops, Thinkpad E14 Gen 2 and Thinkpad 13s-IML > > also require to disable the tpm_tis interrupts for avoiding a boot > > hang. > > > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > Cc: # v6.4+ > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213779 > > Signed-off-by: Takashi Iwai > > > > --- > > drivers/char/tpm/tpm_tis.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > index a98773ac2e55..0633823dc515 100644 > > --- a/drivers/char/tpm/tpm_tis.c > > +++ b/drivers/char/tpm/tpm_tis.c > > @@ -130,6 +130,22 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > DMI_MATCH(DMI_PRODUCT_NAME, "Laptop (13th Gen Intel Core)"), > > }, > > }, > > + { > > + .callback = tpm_tis_disable_irq, > > + .ident = "ThinkPad E14 Gen 2", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad E14 Gen 2"), > > + }, > > + }, > > + { > > + .callback = tpm_tis_disable_irq, > > + .ident = "ThinkBook 13s-IML", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ThinkBook 13s-IML"), > > + }, > > + }, > > { > > .callback = tpm_tis_disable_irq, > > .ident = "ThinkPad T490s", > > -- > > 2.35.3 > > As almost all issues are with Lenovo, I would instead just put: > > { > .callback = tpm_tis_disable_irq, > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > }, > }, > > And delete the existing entries with vendor as "LENOVO". Yeah, that will relieve pains better, too. thanks, Takashi