From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3ECEB64DA for ; Wed, 19 Jul 2023 08:01:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbjGSIBc (ORCPT ); Wed, 19 Jul 2023 04:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjGSIB3 (ORCPT ); Wed, 19 Jul 2023 04:01:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D90C21736 for ; Wed, 19 Jul 2023 01:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689753645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eIfBH5EFlV65x3IEf/u6Gtm7XoEhIOJBMMqfp8v5VTQ=; b=LrFRaAtOl1F2YXXEGyLuSrme9sTSCubyDs3N5jPx6iQzE26jgEQfEhMSh3j1CDsnDcQr5W 55FwqzFoihUI7ZesoB/mxYVUZFlGJQ0ZIcVZDzghkbJ2rKPHVZgfyw9Yk8kn02gtcK9Nfw xVgyxKpYXQl0HBKSGuQO078BeFVONAc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-9RPdH_n_PHWsaTnYdLWjdw-1; Wed, 19 Jul 2023 04:00:43 -0400 X-MC-Unique: 9RPdH_n_PHWsaTnYdLWjdw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fc0094c1bdso41281845e9.2 for ; Wed, 19 Jul 2023 01:00:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689753642; x=1690358442; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eIfBH5EFlV65x3IEf/u6Gtm7XoEhIOJBMMqfp8v5VTQ=; b=HFXe4tRRdnCXo+uiUBsMQ+H1yRPZftpmaAtxELWp7iqmR8lldpajMeS4vZt/o8cUmm rqQlJk6dk/JR0l44oIzXbOAhFsDztHJyqzPiLbl9bSDq/26h1Rxee7l9auQxDiJ0tT95 BTLmxBWVao6Xr8l/GOs6vBvX0lfxRQkh2HptXCjjUUrBppV6kbog6aP3TukgUx0qMjMf c0z4YtceXfwNfTqciuysI9qycoG2Rp2woA7iIqwLpFmittCTT4HQc4N6vcgg/X7UkgSP /MRY5j/HxPO6dOlAZcHfewtiJysp75LF3RjIlnf0NIZOUhEg9eEwmHEEtghCWyp14CDA UDhQ== X-Gm-Message-State: ABy/qLYDA1ZM7ZSaVvnmIsbBAzHYEcjJNRteR0GgwzJrY8ojOaTuyH6a vEMGGR9h0kG4Od+5a6P40VMqaGCirvcCtjPyBzx0k3BjOuHIiWU7z+Z1LcbG/HVNP46M8H7bIKk 1RKAqhzXkn7KsTMQcSZ7Wbppq X-Received: by 2002:a05:600c:3658:b0:3fb:b008:2003 with SMTP id y24-20020a05600c365800b003fbb0082003mr3825133wmq.38.1689753642470; Wed, 19 Jul 2023 01:00:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGntWPiUul+16y14wCIszAKkF4hXHNsg4spAPjjzeZmXkHbvOBJ578nYz2u9Y1aY8JZQP2r2g== X-Received: by 2002:a05:600c:3658:b0:3fb:b008:2003 with SMTP id y24-20020a05600c365800b003fbb0082003mr3825125wmq.38.1689753642287; Wed, 19 Jul 2023 01:00:42 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id t24-20020a1c7718000000b003fba137857esm1042775wmi.14.2023.07.19.01.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 01:00:42 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , linux-kernel@vger.kernel.org Cc: Geert Uytterhoeven , Thomas Zimmermann , Andy Shevchenko , Borislav Petkov , Daniel Thompson , Daniel Vetter , Dave Hansen , Dave Airlie , Greg Kroah-Hartman , "H. Peter Anvin" , Helge Deller , Ingo Molnar , Jacek Lawrynowicz , Jingoo Han , Lee Jones , Maarten Lankhorst , Maxime Ripard , Melissa Wen , Nipun Gupta , Oded Gabbay , Randy Dunlap , Sam Ravnborg , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 0/4] Allow disabling all native fbdev drivers and only keeping DRM emulation In-Reply-To: <24a36694-6813-47fd-ab30-b939a81935e7@app.fastmail.com> References: <20230714171642.91185-1-javierm@redhat.com> <24a36694-6813-47fd-ab30-b939a81935e7@app.fastmail.com> Date: Wed, 19 Jul 2023 10:00:41 +0200 Message-ID: <87ilagib4m.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Arnd Bergmann" writes: > On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote: >> This patch series splits the fbdev core support in two different Kconfig >> symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to >> be disabled, while still having the the core fbdev support needed for the >> CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically >> disabling all fbdev drivers instead of having to be disabled individually. >> >> The reason for doing this is that now with simpledrm, there's no need for >> the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros >> now disable them. But it would simplify the config a lot fo have a single >> Kconfig symbol to disable all fbdev drivers. >> >> I've built tested with possible combinations of CONFIG_FB, CONFIG_FB_CORE, >> CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE symbols set to 'y' or 'n'. >> >> Patch #1 moves the auxdisplay drivers to "Graphics support" Kconfig menu, >> patch #2 moves the core fbdev Kconfig symbols to a separate Kconfig file, >> patch #3 does the FB symbol split and introduces the FB_CORE symbol and >> finally patch #4 makes the DRM symbol to select FB_CORE if the DRM fbdev >> emualtion support was enabled. >> >> Since this series touches three subsystems (auxdisplay, fbdev and DRM), >> I would like to merge it through DRM with the acks of these maintainers. >> >> This is a v5 of the patch-set that addresses issues pointed out by Arnd >> Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4: >> >> https://lists.freedesktop.org/archives/dri-devel/2023-July/411842.html > > Looks all good to me, except for two minor things I found in build testing > and replied to separately. With those fixed: > > Reviewed-by: Arnd Bergmann > Tested-by: Arnd Bergmann > Awesome, thanks a lot for your help! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat