From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFBFC77B7D for ; Wed, 17 May 2023 14:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbjEQO5S (ORCPT ); Wed, 17 May 2023 10:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjEQO5Q (ORCPT ); Wed, 17 May 2023 10:57:16 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DD6FE77 for ; Wed, 17 May 2023 07:56:50 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F129B22564; Wed, 17 May 2023 14:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684335408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ibgoaQed0YOZPO31PdHH3INact4M7VrxIu1eAcWFcw=; b=Eaxtbu7+hesNpvOcSw4cLsY18CTAqscNbzhT4X18jGx30XFI6n1qIyCL1zgbopNwqJoNbT a5zyAn9gAqSzBMniSmFkrzfYmWh/pu3blbeXQyM/xqnKp45taJeZWn35v98r7jtEnQauQs 7iSBSoqjbNW5uDY2IwJ1oOQHKRh7rPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684335408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9ibgoaQed0YOZPO31PdHH3INact4M7VrxIu1eAcWFcw=; b=atJLcGeW0wJEnF7iVC+vqWmSmlLSAO9qdHZCKgN5ccbhmOSwvyXLe7gTLwsgLAUpFy4OY2 R9TLcAIcjSlGppAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C804013358; Wed, 17 May 2023 14:56:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MVC6LzDrZGT3dAAAMHmgww (envelope-from ); Wed, 17 May 2023 14:56:48 +0000 Date: Wed, 17 May 2023 16:56:48 +0200 Message-ID: <87ilcr0zwv.wl-tiwai@suse.de> From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ALSA: cs46xx: mark snd_cs46xx_download_image as static In-Reply-To: <20230516195046.550584-1-arnd@kernel.org> References: <20230516195046.550584-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 May 2023 21:50:41 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > snd_cs46xx_download_image() was originally called from dsp_spos.c, but > is now local to cs46xx_lib.c. Mark it as 'static' to avoid a warning > about it lacking a declaration, and '__maybe_unused' to avoid a warning > about it being unused when CONFIG_SND_CS46XX_NEW_DSP is disabled: > > sound/pci/cs46xx/cs46xx_lib.c:534:5: error: no previous prototype for 'snd_cs46xx_download_image' > > Fixes: 89f157d9e6bf ("[ALSA] cs46xx - Fix PM resume") > Signed-off-by: Arnd Bergmann Thanks, applied now. Takashi