From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35128C433FE for ; Wed, 5 Oct 2022 09:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229724AbiJEJpo (ORCPT ); Wed, 5 Oct 2022 05:45:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbiJEJpk (ORCPT ); Wed, 5 Oct 2022 05:45:40 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 214876B158 for ; Wed, 5 Oct 2022 02:45:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BA6B91F74A; Wed, 5 Oct 2022 09:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664963138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rU0w0PCNKN0xXBXplJAZJuCSubVSrIsbg46jxnYU5Ro=; b=PO7heKsi5Ujyvjqb3tStJBoAaD6SptlguubNdL61Q7aEbrlvFhCSoWk+tkMKNWhpiTg4tS g3ks5FHa6652/SI5pWZxO/Og3xyTPfvMg57L8TLvyLGltG8qy+M+4WmH/5I2W5H8HdmPpO TrocfGRE5PrEABJeH0ubf2ZHX4TmaLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664963138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rU0w0PCNKN0xXBXplJAZJuCSubVSrIsbg46jxnYU5Ro=; b=PL4zm892o+gVvk86gFP/JfU+yRGr+WLxUCJl4MPQrA2eM3NKILtprURJztcgEGpW8YrJ8d +guh7sMTWYkU3hBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84D0B13345; Wed, 5 Oct 2022 09:45:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MLylH0JSPWNCIAAAMHmgww (envelope-from ); Wed, 05 Oct 2022 09:45:38 +0000 Date: Wed, 05 Oct 2022 11:45:37 +0200 Message-ID: <87ilkyvc1q.wl-tiwai@suse.de> From: Takashi Iwai To: "Lu, Brent" Cc: "alsa-devel@alsa-project.org" , "Jaroslav Kysela" , Takashi Iwai , Kai Vehmanen , Pierre-Louis Bossart , Mohan Kumar , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , "Zhi, Yong" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ALSA: hda/hdmi: run eld notify in delay work In-Reply-To: References: <20220927135807.4097052-1-brent.lu@intel.com> <87ill8gb5c.wl-tiwai@suse.de> <875yh8ezs9.wl-tiwai@suse.de> <871qrvgbsr.wl-tiwai@suse.de> <87y1u3evy6.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 05 Oct 2022 10:14:19 +0200, Lu, Brent wrote: > > > > > ... and on the further consideration, I believe the best solution is to just get rid of > > the whole check. > > > > It was introduced by the commit eb399d3c99d8 along with the 8ae743e82f0b > > that checks the suspend state. The latter is still meaningful (we should skip the > > bogus notification at suspend). > > However, the former -- the code path we're dealing with -- doesn't help much in > > the recent code. That fix was required because the driver probed the ELD bits > > via HD-audio verb at the time of the fix commit; that is, the driver had to wake > > up the codec for updating the ELD. OTOH, now ELD is read directly from the > > graphics chip without the codec wakeup. So the skip makes little sense. > Hi Takashi, > > I've got the test result from ODM which is positive. During 60 test runs, the elf notify > running in suspend happened 10 times and the audio is normal. The patch is looking > good. Thanks for confirmation. The fix will be included in 6.1-rc1. Takashi