From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A3CC433F5 for ; Tue, 4 Jan 2022 13:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233748AbiADNom (ORCPT ); Tue, 4 Jan 2022 08:44:42 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:40076 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233769AbiADNoe (ORCPT ); Tue, 4 Jan 2022 08:44:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51D8061435 for ; Tue, 4 Jan 2022 13:44:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6E1DC36AE9; Tue, 4 Jan 2022 13:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641303873; bh=meSSg/YmNbksR9ORav1v/bOv0Oo6+Koppmo78YLMnIQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mXJopMPoRAwqub3ro5VAA6/y7RCrAGRKjh3JRwztH91E50zE67fnYuiI95IwLjxYM XzoR9b/DSZZtj85pabIlt28CO5xsdckUTKKPr2Rrhhm6UAPztxTqYz/bXhfrnvQJHX MDOMIv1O9/RFWz+wd4sUz4SzVOJ5f0yRfehaaZuEbiYx/upt/x0SnC0SLk0/P0IqsC vl3UhkBq3XM+fKk+8iCO8SK6Gb4O7COY3TZPpT0f2xoGIRG6jzWAnWTwZJipZb2kBk cJLC9AEOVtISZrE53II4HTwmXQLzelEsfxx+qHKU/XOfKoBD+/rChWfaB9h1FJ85s1 Ni7Y+6z2JpwDA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4k75-00FvHK-Ih; Tue, 04 Jan 2022 13:44:31 +0000 Date: Tue, 04 Jan 2022 13:44:31 +0000 Message-ID: <87iluzvcn4.wl-maz@kernel.org> From: Marc Zyngier To: Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, James Morse , Alexandru Elisei , Suzuki K Poulose Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions In-Reply-To: References: <20211222165552.69288-1-andriy.shevchenko@linux.intel.com> <8735mk1pgt.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Dec 2021 19:14:28 +0000, Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote: > > > On Wed, 22 Dec 2021 16:55:52 +0000, > > > Andy Shevchenko wrote: > > > > > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > especially when there are circular dependencies are involved. > > > > > > Which circular dependencies? What problem are you solving? > > > > In particular moving bitmap_*alloc() APIs to the headers. > > > > But this may be a side effect of what I realized during the attempts > > of solving that issue. In any case there is no need to take entire > > mess of kernel.h in another header. > > For the record `make headerdep` doesn't make any difference with > or without this patch. But I consider it's better not to use kernel.h > in the headers due to a full mess behind it. Can you then please write a commit message that matches what this is actually doing instead of mentioning a problem that doesn't seem to exist? Thanks, M. -- Without deviation from the norm, progress is not possible.