From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96991C433E0 for ; Thu, 24 Dec 2020 01:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 508202251F for ; Thu, 24 Dec 2020 01:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbgLXBGb (ORCPT ); Wed, 23 Dec 2020 20:06:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbgLXBGb (ORCPT ); Wed, 23 Dec 2020 20:06:31 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5539C061794 for ; Wed, 23 Dec 2020 17:05:50 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4D1X2320TZz9sWX; Thu, 24 Dec 2020 12:05:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1608771947; bh=CL3AnHOz06mrGbhgw6tM4Noc2JcCqYwI4iu0BsEovkk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fCiucknv8nL9x1/qU3U+wOdvGZCd6NIyqFGZNxwe605kmn9m1Y3iU8lFekIv/MbRs KgGzk4os0Uj70EK6ulPJd7VEB/AQ69hubpSEAJWOObpUa+6aAr8XTjyTuCebWT+IIR 1g+Ah5eczZ3TvJu6EGtfjazPe1waUuPVZPr8SspE4WzGXxMPdhuQQX8ZRBIWqsnBGL 3Mhqes70K5LsI366MyIQYkfrqbSmj6PeBXXCvXVqiNumGlNbB3PTUm1yZbVPNfNdKl AyX6R+0tuTJR2sjq+JBZYo0LwVWw45rFcAHo6DWSkwpktYqfyRM0rwBuTt7TEE6/B5 U7zEYoB7AsUNg== From: Michael Ellerman To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack In-Reply-To: <6ed0b74d-8d01-4a20-faed-891496fb77b4@csgroup.eu> References: <6ed0b74d-8d01-4a20-faed-891496fb77b4@csgroup.eu> Date: Thu, 24 Dec 2020 12:05:43 +1100 Message-ID: <87im8s6mjc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 22/12/2020 =C3=A0 08:11, Christophe Leroy a =C3=A9crit=C2=A0: >> When we have VMAP stack, exception prolog 1 sets r1, not r11. > > But exception prolog 1 uses r1 to setup r1 when machine check happens in = kernel. > So r1 must be restored when the branch is not taken. See subsequent patch= I just sent out. OK. This is still on the tip of fixes, so I'll rewind it to drop this commit, and then apply this and the fixup as one patch next week. cheers