From: John Ogness <john.ogness@linutronix.de>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next v2 1/2] printk: avoid and/or handle record truncation
Date: Wed, 30 Sep 2020 12:30:50 +0206 [thread overview]
Message-ID: <87imbv1s0d.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20200930094316.GB987@jagdpanzerIV.localdomain>
On 2020-09-30, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> On (20/09/30 11:07), John Ogness wrote:
>> bool prb_reserve_in_last(struct prb_reserved_entry *e, struct printk_ringbuffer *rb,
>> - struct printk_record *r, u32 caller_id);
>> + struct printk_record *r, u32 caller_id, unsigned int max_size);
>
> Isn't `max_size' always LOG_LINE_MAX?
Yes. But I still think it makes sense that it is an argument of the
function. It is quite an important setting and hard-coding it within the
ringbuffer code might lead to hidden problems later.
John Ogness
next prev parent reply other threads:[~2020-09-30 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:01 [PATCH next v2 0/2] printk: fix reading beyond buffer John Ogness
2020-09-30 9:01 ` [PATCH next v2 1/2] printk: avoid and/or handle record truncation John Ogness
2020-09-30 9:43 ` Sergey Senozhatsky
2020-09-30 10:24 ` John Ogness [this message]
2020-09-30 11:28 ` Petr Mladek
2020-09-30 11:42 ` John Ogness
2020-09-30 11:53 ` Petr Mladek
2020-09-30 23:25 ` Sergey Senozhatsky
2020-09-30 13:29 ` Petr Mladek
2020-09-30 15:25 ` Joe Perches
2020-10-01 7:26 ` Petr Mladek
2020-10-01 7:39 ` Joe Perches
2020-10-01 7:54 ` Petr Mladek
2020-09-30 9:01 ` [PATCH next v2 2/2] printk: reduce setup_text_buf size to LOG_LINE_MAX John Ogness
2020-09-30 13:30 ` [PATCH next v2 0/2] printk: fix reading beyond buffer Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbv1s0d.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®