From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Benjamin LaHaise <bcrl@kvack.org>, Arnd Bergmann <arnd@arndb.de>,
David Laight <David.Laight@aculab.com>,
Deepa Dinamani <deepa.kernel@gmail.com>, Eric Wong <e@80x24.org>,
linux-aio@kvack.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] aio: simplify the usage of restore_saved_sigmask_unless()
Date: Fri, 07 Jun 2019 13:02:50 -0500 [thread overview]
Message-ID: <87imthclyt.fsf@xmission.com> (raw)
In-Reply-To: <CAHk-=wif34nPB2uzU2YBXXYe5cFZhoLmU_zOtExd74X1WcYXJg@mail.gmail.com> (Linus Torvalds's message of "Fri, 7 Jun 2019 10:37:27 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Fri, Jun 7, 2019 at 10:33 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> Are they actually nonrestartable? I think the current EINTR is just a mistake.
>
> Oh, I guess they are, because of the relative timeout thing that
> shouldn't reset to the original value.
>
> And I don't think this is worth a ERESTAR_RESTARTTBLOCK.
Unless I am misreading things io_pgetevents isn't restartable
either and ERESTARTNOHAND is a bug in that case.
Is the bug going the other way?
Eric
next prev parent reply other threads:[~2019-06-07 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 10:31 [PATCH -mm 0/2] aio: simplify/fix " Oleg Nesterov
2019-06-07 10:31 ` [PATCH 1/2] aio: simplify " Oleg Nesterov
2019-06-07 17:33 ` Linus Torvalds
2019-06-07 17:37 ` Linus Torvalds
2019-06-07 18:02 ` Eric W. Biederman [this message]
2019-06-07 18:09 ` Linus Torvalds
2019-06-07 10:32 ` [PATCH 2/2] aio: fix " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imthclyt.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcrl@kvack.org \
--cc=deepa.kernel@gmail.com \
--cc=e@80x24.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome