From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751511AbdK0HYD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Nov 2017 02:24:03 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:37529 "EHLO
        mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751197AbdK0HYA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Nov 2017 02:24:00 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20171127072357euoutp02edb5cf60802a48f8ebfd048dd838a96a~64HmP6TMq2457724577euoutp02O
X-AuditID: cbfec7ef-f79ee6d000003120-5d-5a1bbd8c4fac
From: =?utf-8?Q?=C5=81ukasz_Stelmach?= <l.stelmach@samsung.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Krzysztof Kozlowski <krzk@kernel.org>, devicetree@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver
In-reply-to: <CANc+2y4=Eas-i0jRwgTxqFeAngpPMKoUjVwsXWeU7G24g4252w@mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Date: Mon, 27 Nov 2017 08:23:50 +0100
Message-id: <87indwchh5.fsf%l.stelmach@samsung.com>
MIME-version: 1.0
Content-type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIKsWRmVeSWpSXmKPExsWy7djPc7o9e6WjDNbOkLPYOGM9q8X8I+dY
        LbpfyVicP7+B3eL+vZ9MFpd3zWGzmHF+H5PF2iN32S0WbOtjtFjaf5zRonXvEXYHbo+ds+6y
        e2w7oOqxaVUnm0ffllWMHn0vNzB6fN4kF8AWxWWTkpqTWZZapG+XwJUx6ZdwwQquis+H77E1
        MJ7l6GLk5JAQMJHY83w7M4QtJnHh3nq2LkYuDiGBZYwS91ecZwVJCAl8ZpS4cFMbpmHHpgms
        cEWHvixhhHC+MEos/b+aEaSKTcBeov/IPpYuRg4OEQFriS0PVEFqmAX+Mkm0Lu5hBokLC3hL
        TPlvDVLOKRAssb51N1irqIClxL2+u2wgNouAqsS8P4/AjuAVMJZY2b+JCcIWlPgx+R4LiM0s
        kCvxqek/O8h8CYF+dom+95vYIC51kbiz8xArhC0s8er4FnYIW0bi8uRuFqgGRonD879DJaYw
        Sixe6ABhW0v8WTWRDWIDn8SkbdPBjpYQ4JXoaBOCMD0kbvzXgah2lLhwfTITJByWMEpMubiB
        cQKj7Cwkt85CcussoHZmAU2J9bv0IcLaEssWvmaGsG0l1q17z7KAkXUVo0hqaXFuemqxoV5x
        Ym5xaV66XnJ+7iZGYOI5/e/4+x2MT5tDDjEKcDAq8fAq+EhHCbEmlhVX5h5iVAEa82jD6guM
        Uix5+XmpSiK8AuVSUUK8KYmVValF+fFFpTmpxYcYpTlYlMR5baPaIoUE0hNLUrNTUwtSi2Cy
        TBycUg2MKy8842WrX6vHduum5Pe8k6L3zt841J5xY+EH7sPZvxNXBRpfW71yXgFLtse+3Oja
        1scbNZa/jvmib7NQ/uw6pYP8bKHz7ar8d+QtYo/QP3PA6PbdGjmRVmGzhv6jsz80uCvOndZw
        T/pIxONzvS06Cg8EWZ/oibpMrbyjl3I2zeZfobL3gq9nlFiKMxINtZiLihMB3Mt8ykQDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Nd3uvdJRBrf+mltsnLGe1WL+kXOs
        Ft2vZCzOn9/AbnH/3k8mi8u75rBZzDi/j8li7ZG77BYLtvUxWiztP85o0br3CLsDt8fOWXfZ
        PbYdUPXYtKqTzaNvyypGj76XGxg9Pm+SC2CL4rJJSc3JLEst0rdL4MqY9Eu4YAVXxefD99ga
        GM9ydDFyckgImEjs2DSBFcIWk7hwbz1bFyMXh5DAEkaJRZ8us0A43xglTjZsZgKpYhOwl+g/
        sg8owcEhImAtseWBKkgNs8BfJollbw4zgsSFBbwlpvy3BinnFAiWuLdiBjOILSQQILHg9lRG
        EFtUwFLiXt9dNhCbRUBVYt6fR2BH8AoYS6zs38QEYQtK/Jh8jwXEZhbIlrhw8Q3LBEb+WUhS
        s5CkZgFtZhbQlFi/Sx8irC2xbOFrZgjbVmLduvcsCxhZVzGKpJYW56bnFhvpFSfmFpfmpesl
        5+duYgRGybZjP7fsYOx6F3yIUYCDUYmHV8FHOkqINbGsuDL3EKMK0JhHG1ZfYJRiycvPS1US
        4RUol4oS4k1JrKxKLcqPLyrNSS0+xCjNwaIkztu7Z3WkkEB6YklqdmpqQWoRTJaJg1OqgXHp
        iQm7XnledTIrOsP/V/F1x8wtRYEr/eJXKRk9brG+76rMLzt/5v7j/77M2Hgr9cuJ6V8ma/Q2
        HG5W9pGRFJLY57q/PJv1vcb9hl0KnCevaFvkeoaLWZgcfFD9c13HTaZJJQ3nXbniN30xzzBx
        +Zy4hYHzVsOpY+/lLz0L4JC9d1TqSbN++i4lluKMREMt5qLiRABnY5SxmgIAAA==
X-CMS-MailID: 20171127072355eucas1p218e3cbaeb1ba16b5a1262deda350d850
X-Msg-Generator: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20171127072355eucas1p218e3cbaeb1ba16b5a1262deda350d850
X-RootMTR: 20171127072355eucas1p218e3cbaeb1ba16b5a1262deda350d850
References: <CANc+2y4=Eas-i0jRwgTxqFeAngpPMKoUjVwsXWeU7G24g4252w@mail.gmail.com>
        <CGME20171127072355eucas1p218e3cbaeb1ba16b5a1262deda350d850@eucas1p2.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2017-11-24 pi=C4=85 16:25>, when PrasannaKumar Muralidharan wrote:
>> +}
>> +
>> +static int exynos_trng_do_read(struct hwrng *rng, void *data, size_t ma=
x,
>> +                              bool wait)
>> +{
>> +       struct exynos_trng_dev *trng;
>> +       u32 val;
>> +
>> +       max =3D max > (EXYNOS_TRNG_FIFO_LEN * 4) ?
>> +               (EXYNOS_TRNG_FIFO_LEN * 4) : max;
>
> max is always > 32. This condition is not required.

No, it is not. http://elixir.free-electrons.com/linux/latest/source/drivers=
/char/hw_random/core.c#L67
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJaG72GAAoJELCuHpyYpYAQ7TwH/RluMZvecCAMUJ+TOwqhwmo8
Pnd91DSwwzYfQdNuXapahStONC3jjrQOd6eRaKrxo6084H9iUpSeJIiZhBMvduDu
jvgi3Se+IkrlNZgsXeLHeTrxDoUvutib7tklV2yhrNEx5K/Yduf5/h5cK+jwCTzU
8ptGH41kAbRcMSwEau2MBYf48a0gWru27cFiSTIymdIjqHMBZH41BZSpdh0ivKnW
7nDd3+ZIANec+xyzt03fvHijtPOJlDjTN5N1ai+BC7DSc18EnPb58TaoYa1A1LQD
NjXi3SlzW9c2Xa3KdogCxQcOdLGMcGmEMq+KsFIkN0uJzS3aHMed2b+Gudo7GvU=
=mKSe
-----END PGP SIGNATURE-----
--=-=-=--