From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbdJDMhx (ORCPT ); Wed, 4 Oct 2017 08:37:53 -0400 Received: from ozlabs.org ([103.22.144.67]:55263 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdJDMhv (ORCPT ); Wed, 4 Oct 2017 08:37:51 -0400 From: Michael Ellerman To: Rob Herring Cc: "devicetree\@vger.kernel.org" , linuxppc-dev , "linux-kernel\@vger.kernel.org" , Frank Rowand , Benjamin Herrenschmidt , Paul Mackerras , David Laight , "nfont\@linux.vnet.ibm.com" , "tyreld\@linux.vnet.ibm.com" Subject: Re: [PATCH v2 4/5] powerpc: pseries: only store the device node basename in full_name In-Reply-To: References: <20170821151651.25096-1-robh@kernel.org> <20170821151651.25096-5-robh@kernel.org> <87tvzgd1l3.fsf@concordia.ellerman.id.au> Date: Wed, 04 Oct 2017 23:37:49 +1100 Message-ID: <87infvozqa.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > On Tue, Oct 3, 2017 at 4:26 AM, Michael Ellerman wrote: ... >> >> The obvious fix is just to allocate it separately as before, eg ~=: > > Yes, I'll go back to doing 2 allocs like v1, but using kstrdup as was > also pointed out. Yeah that would be better still I guess. cheers