From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 6/6] cpufreq: pxa: convert to clock API
Date: Wed, 12 Oct 2016 10:29:05 +0200 [thread overview]
Message-ID: <87insy6kdq.fsf@belgarion.home> (raw)
In-Reply-To: <20161012063247.GH19385@vireshk-i7> (Viresh Kumar's message of "Wed, 12 Oct 2016 12:02:47 +0530")
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 12-10-16, 08:22, Robert Jarzmik wrote:
>> Viresh Kumar <viresh.kumar@linaro.org> writes:
>>
>> > On 10-10-16, 22:09, Robert Jarzmik wrote:
>> >> As the clock settings have been introduced into the clock pxa drivers,
>> >> which are now available to change the CPU clock by themselves, remove
>> >> the clock handling from this driver, and rely on pxa clock drivers.
>> >>
>> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>> >> ---
>> >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++-------------------------------
>> >> 1 file changed, 39 insertions(+), 152 deletions(-)
>> >
>> > As you mentioned in the previous patch, why can't you use cpufreq-dt
>> > driver now and delete this one ?
>>
>> PXA architecture have both legacy platform_data based configurations and new
>> devicetree based ones.
>
> I don't see any platform data specific code in this driver. What am I
> missing ?
In a legacy platform, ie. without devicetree, we have CONFIG_OF=n.
How would cpufreq-dt be usable in this case ?
You can see such a platform in arch/arm/configs/mainstone_defconfig and
arch/arm/mach-pxa/mainstone.c as an example.
Cheers.
--
Robert
next prev parent reply other threads:[~2016-10-12 8:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 20:09 [PATCH 0/6] Make pxa core clocks settable Robert Jarzmik
2016-10-10 20:09 ` [PATCH 1/6] clk: pxa: remove unused variables Robert Jarzmik
2016-10-10 20:09 ` [PATCH 2/6] clk: pxa: core pll is not affected by t bit Robert Jarzmik
2016-10-10 20:09 ` [PATCH 3/6] clk: pxa: b bit of clkcfg means fast bus Robert Jarzmik
2016-10-10 20:09 ` [PATCH 4/6] clk: pxa: export core clocks Robert Jarzmik
2016-10-10 20:09 ` [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq Robert Jarzmik
2016-10-18 7:00 ` Robert Jarzmik
2016-10-18 23:48 ` Stephen Boyd
2016-10-19 20:15 ` Robert Jarzmik
2016-10-19 20:51 ` Stephen Boyd
2016-10-20 3:44 ` Viresh Kumar
2016-10-10 20:09 ` [PATCH 6/6] cpufreq: pxa: convert to clock API Robert Jarzmik
2016-10-12 2:36 ` Viresh Kumar
2016-10-12 6:22 ` Robert Jarzmik
2016-10-12 6:32 ` Viresh Kumar
2016-10-12 8:29 ` Robert Jarzmik [this message]
2016-10-12 8:40 ` Viresh Kumar
2016-10-12 19:12 ` Robert Jarzmik
2016-10-15 19:42 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87insy6kdq.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®