From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@lists.codethink.co.uk, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org, Evan Wang <xswang@marvell.com>
Subject: Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static
Date: Mon, 11 Jul 2016 18:00:33 +0200 [thread overview]
Message-ID: <87inwctba6.fsf@free-electrons.com> (raw)
In-Reply-To: <9446011.bTD6e4eDRY@wuerfel> (Arnd Bergmann's message of "Tue, 21 Jun 2016 17:31:13 +0200")
Hi Ben,
On mar., juin 21 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
>>
>> -struct syscore_ops mvebu_mbus_syscore_ops = {
>> +static struct syscore_ops mvebu_mbus_syscore_ops = {
>> .suspend = mvebu_mbus_suspend,
>> .resume = mvebu_mbus_resume,
>> };
>>
>
>
> Looks good, but I immediately thought it should be "const" as well.
> Unfortunately there is a list_head in them, so that isn't easy,
> but if anyone has an idea for how to make these all const, that
> would be nice.
>
> Anyway, that shouldn't stop your patch from getting merged, so
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> (also for patch 1/2).
So I applied both patch in mvebu/cleanup
Thanks,
Gregory
>
> Arnd
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2016-07-11 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 15:16 [PATCH 1/2] bus: mvebu-mbus: fix __iomem on register pointers Ben Dooks
2016-06-21 15:16 ` [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static Ben Dooks
2016-06-21 15:31 ` Arnd Bergmann
2016-07-11 16:00 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inwctba6.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=xswang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome