Re: [LKP] [userns] BUG: unable to handle kernel NULL pointer dereference at (null)

[ebiederm@xmission.com (Eric W. Biederman)]

Huang Ying <ying.huang@intel.com> writes:

> FYI, we noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-testing
> commit bbea5f5532501fdd67f46442ba7b1122d7ff3123 
> ("userns: Add a knob to disable setgroups on a per user namespace basis")

Thank you.

I am quite puzzled by this failure.  There was an similar failure when
/proc/[pid]/setgroups was read (if I recall correctly).  I don't see how
that change could result at failures during open or failures during
boot.  I added a new file to proc which any reasonable system should
leave alone.  Are you by chance running trinity during boot?

If the reproducer gave me any clue about which file that was opened or
which code path this happened on I would be bery interested.  If for no
other reason that to confirm that I have fixed the issue.

I have rewritten the implementation of /proc/[pid]/setgroups so it is
simpler and more robust and does not have any errors I can detect.

Thank you very much for picking up my for-testing branch and beating up
on it.

Eric