From: Namhyung Kim <namhyung@kernel.org>
To: Rodrigo Campos <rodrigo@sdfg.com.ar>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
paulus@samba.org, mingo@redhat.com, acme@ghostprotocols.net
Subject: Re: [PATCH] perf: Remove unneeded include
Date: Thu, 07 Nov 2013 16:07:03 +0900 [thread overview]
Message-ID: <87iow4wuzs.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1383776454-10595-1-git-send-email-rodrigo@sdfg.com.ar> (Rodrigo Campos's message of "Wed, 6 Nov 2013 22:20:54 +0000")
Hi Rodrigo,
On Wed, 6 Nov 2013 22:20:54 +0000, Rodrigo Campos wrote:
> There is no point in sort.h including itself.
>
> The include was added when the file was created, in commit "perf tools: Create
> util/sort.and use it" (dd68ada2d) and added a include to "sort.h" in lot of
> files (all the files that started using the file). It was probably added by
> mistake on sort.h too.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
next prev parent reply other threads:[~2013-11-07 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 22:20 Rodrigo Campos
2013-11-07 7:07 ` Namhyung Kim [this message]
2013-11-07 15:31 ` [tip:perf/core] perf tools: " tip-bot for Rodrigo Campos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iow4wuzs.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome