mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Hyeoncheol Lee <cheol.lee@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	"zhangwei\(Jovi\)" <jovi.zhangwei@huawei.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 12/13] tracing/uprobes: Add more fetch functions
Date: Wed, 28 Aug 2013 14:37:45 +0900	[thread overview]
Message-ID: <87ioyqv0ie.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <521C9594.30901@hitachi.com> (Masami Hiramatsu's message of "Tue, 27 Aug 2013 21:03:32 +0900")

Hi Masami,

On Tue, 27 Aug 2013 21:03:32 +0900, Masami Hiramatsu wrote:
> (2013/08/27 17:48), Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Implement uprobe-specific stack and memory fetch functions and add
>> them to the uprobes_fetch_type_table.  Other fetch fucntions will be
>> shared with kprobes.

[SNIP]
>> +
>> +static unsigned long get_user_stack_nth(struct pt_regs *regs, unsigned int n)
>> +{
>> +	struct vm_area_struct *vma;
>> +	unsigned long addr = GET_USP(regs);
>
> I recommend you to use user_stack_pointer() rather than GET_USP here.
> Since some arch seem not to have correct GET_USP implementation (e.g. arm),
> kernel build will be failed.

Okay, I'll change to the user_stack_pointer().

>
> And at least trace_probe.c part is good for me.
>
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks for your review!
Namhyung

  reply	other threads:[~2013-08-28  5:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  8:48 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v4) Namhyung Kim
2013-08-27  8:48 ` [PATCH 01/13] tracing/uprobes: Fix documentation of uprobe registration syntax Namhyung Kim
2013-08-27  8:48 ` [PATCH 02/13] tracing/probes: Fix basic print type functions Namhyung Kim
2013-08-27  8:48 ` [PATCH 03/13] tracing/kprobes: Move fetch functions to trace_kprobe.c Namhyung Kim
2013-08-27  8:48 ` [PATCH 04/13] tracing/kprobes: Add fetch{,_size} member into deref fetch method Namhyung Kim
2013-08-27  8:48 ` [PATCH 05/13] tracing/kprobes: Staticize stack and memory fetch functions Namhyung Kim
2013-08-27  8:48 ` [PATCH 06/13] tracing/kprobes: Factor out struct trace_probe Namhyung Kim
2013-08-27  8:48 ` [PATCH 07/13] tracing/uprobes: Convert to " Namhyung Kim
2013-08-27  8:48 ` [PATCH 08/13] tracing/kprobes: Move common functions to trace_probe.h Namhyung Kim
2013-08-27  8:48 ` [PATCH 09/13] tracing/kprobes: Integrate duplicate set_print_fmt() Namhyung Kim
2013-08-27  8:48 ` [PATCH 10/13] tracing/uprobes: Fetch args before reserving a ring buffer Namhyung Kim
2013-08-27  8:48 ` [PATCH 11/13] tracing/kprobes: Add priv argument to fetch functions Namhyung Kim
2013-08-27  8:48 ` [PATCH 12/13] tracing/uprobes: Add more " Namhyung Kim
2013-08-27 12:03   ` Masami Hiramatsu
2013-08-28  5:37     ` Namhyung Kim [this message]
2013-08-27  8:48 ` [PATCH 13/13] tracing/uprobes: Add support for full argument access methods Namhyung Kim
2013-08-27 11:54   ` Masami Hiramatsu
2013-08-28  5:41     ` Namhyung Kim
2013-08-28 11:17       ` Masami Hiramatsu
  -- strict thread matches above, loose matches on Subject: below --
2013-10-29  6:53 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v6) Namhyung Kim
2013-10-29  6:53 ` [PATCH 12/13] tracing/uprobes: Add more fetch functions Namhyung Kim
2013-10-31 18:22   ` Oleg Nesterov
2013-11-04  8:50     ` Namhyung Kim
2013-11-04 16:44       ` Oleg Nesterov
2013-11-04 17:17         ` Steven Rostedt
2013-11-05  2:19           ` Namhyung Kim
2013-11-05  2:17         ` Namhyung Kim
2013-11-01 17:53   ` Oleg Nesterov
2013-09-03  5:44 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v5) Namhyung Kim
2013-09-03  5:44 ` [PATCH 12/13] tracing/uprobes: Add more fetch functions Namhyung Kim
2013-08-09  8:44 [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v3) Namhyung Kim
2013-08-09  8:45 ` [PATCH 12/13] tracing/uprobes: Add more fetch functions Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioyqv0ie.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=cheol.lee@lge.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung.kim@lge.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome