From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663Ab2K2USF (ORCPT ); Thu, 29 Nov 2012 15:18:05 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:46667 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200Ab2K2USE (ORCPT ); Thu, 29 Nov 2012 15:18:04 -0500 From: Jim Meyering To: Dave Chinner Cc: Hugh Dickins , Jaegeuk Hanse , Andrew Morton , "Theodore Ts'o" , Zheng Liu , Jeff liu , Paul Eggert , Christoph Hellwig , Josef Bacik , Andi Kleen , Andreas Dilger , Marco Stornelli , Chris Mason , Sunil Mushran , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise) In-Reply-To: <20121129195206.GB6434@dastard> (Dave Chinner's message of "Fri, 30 Nov 2012 06:52:07 +1100") References: <20121129012933.GA9112@kernel> <87lidlxcw9.fsf@rho.meyering.net> <20121129195206.GB6434@dastard> Date: Thu, 29 Nov 2012 21:17:51 +0100 Message-ID: <87ip8o17v4.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Chinner wrote: ... >> So, yes, GNU cp will soon use this feature. > > It would be nice if utilities like grep used it, too, because having > grep burn gigabytes of memory scanning holes in large files and > then going OOM is, well, kind of nasty: > > $ xfs_io -f -c "truncate 1t" blah > $ ls -l > total 0 > -rw-r--r-- 1 dave dave 1.0T Nov 30 06:42 blah > $ grep foo blah > grep: memory exhausted > $ $ grep -V > grep (GNU grep) 2.12 Hi Dave, Yes, adapting grep is also on the road map. That precise case was one of my arguments for making SEEK_DATA/SEEK_HOLE support more widespread.