From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755584AbZENR57@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755584AbZENR57 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 May 2009 13:57:59 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751805AbZENR5s
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 14 May 2009 13:57:48 -0400
Received: from fg-out-1718.google.com ([72.14.220.155]:37315 "EHLO
	fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751592AbZENR5s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 May 2009 13:57:48 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:message-id:from:to:cc:subject:in-reply-to:references
         :user-agent:mime-version:content-type;
        b=sUqBs51rZJqYE5ykz4QvFlg+6kuXAnymW5a47CzIE3KMLGV4kjTWQ5UXPbuCGAU7xF
         7wDbGPRqWWqqbDBzMPuqmQP8yp5BW8ThwQlI2QBK/NihY1SNjyJZ9WhepeGbSbZh7DWL
         QjrIELw8ukytBuN8v7HlgjQx3VmqjaTMCGnoc=
Date: Thu, 14 May 2009 19:57:46 +0200
Message-ID: <87iqk3zhwl.wl%vmayatsk@redhat.com>
From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Josef Bacik <josef@redhat.com>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>, sandeen@redhat.com,
       linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Introduce check_readable_bytes()
In-Reply-To: <20090514173858.GA10059@dhcp231-156.rdu.redhat.com>
References: <1242317939-15392-1-git-send-email-v.mayatskih@gmail.com>
	<1242317939-15392-2-git-send-email-v.mayatskih@gmail.com>
	<20090514173858.GA10059@dhcp231-156.rdu.redhat.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 14 May 2009 13:40:09 -0400, Josef Bacik wrote:

> > +	volatile char c;
> > +	int ret = 0;
> > +	long page_begin = (unsigned long)uaddr & PAGE_MASK;
> > +	long page_end = ((unsigned long)uaddr + size) & PAGE_MASK;
> > +	long ptr = page_begin;
> > +
> 
> Firstly page_begin/page_end/ptr should all be unsigned long.  Secondly page_end
> should be uaddr+size-1.
> 
> > +	if (unlikely(size == 0))
> > +		goto out;
> > +
> > +	while (!ret && ptr <= page_end) {
> > +		ret = __get_user(c, (const char __user*)ptr);
> > +		if (!ret)
> > +			ptr += PAGE_SIZE;
> > +	}
> > +
> > +	if (likely(!ret))
> > +		ret = size;
> > +	else
> > +		ret = (ptr == page_begin) ?
> > +			-EFAULT : (const char __user *)ptr - uaddr;
> 
> This isn't quite right either, we do some pointer math, and return that and its
> casted as an int?  That seems like a bad idea in general.  Thanks,

Did you like the approach in general?

-- 
wbr, Vitaly