From: Takashi Iwai <tiwai@suse.de>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, thierry.reding@kernel.org,
jonathanh@nvidia.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
tiwai@suse.de, baijiaju1990@gmail.com, jjzuming@gmail.com
Subject: Re: [PATCH v4 0/5] ALSA: hda: Wait for PCM files on codec teardown
Date: Fri, 06 Nov 2026 15:18:24 +0100 [thread overview]
Message-ID: <87jymqoxfz.wl-tiwai@suse.de> (raw)
In-Reply-To: <pm-pmb-a4703edca61d34aa679b-v12-b75145090f6bcd7cf145-0@gmail.com>
On Sat, 31 Oct 2026 06:14:25 +0100,
Cen Zhang wrote:
>
> When an HD-audio codec is unbound while the card stays registered, the
> codec remove frees its PCMs while files can still use them, and the
> probe and remove of codecs on one bus can run at the same time.
>
> Following Takashi's suggestion on v2, this version fixes both in the
> HD-audio layer: patch 1 serializes the codec probe and remove and the
> card registration on a bus, and patch 5 makes the codec teardown wait
> until the files opened on its PCMs are closed.
>
> Patches 2 and 3 add the file to the card while the PCM minor is looked
> up, so that the wait does not miss an open between the lookup and
> snd_card_file_add(), and record the device a file was opened for. The
> teardown waits only for the files of its own PCMs, because the card
> files also include the control device, which a sound server keeps open
> for as long as it runs. Patch 4 makes an open fail once its PCM is
> disconnected, so that a late open does not get a working stream and
> hold off the teardown.
>
> Cen Zhang (5):
> ALSA: hda: Serialize codec probe and remove on the same bus
> ALSA: core: Add the card file while looking up a minor
> ALSA: pcm: Add the file to the card while looking up the minor
> ALSA: pcm: Refuse to open a disconnected PCM
> ALSA: hda: Wait for the files of the codec PCMs before freeing them
Since it's slightly intensive change, I applied to for-next branch
(i.e. for 7.5).
thanks,
Takashi
prev parent reply other threads:[~2026-11-06 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 5:14 Cen Zhang
2026-10-31 5:14 ` [PATCH v4 1/5] ALSA: hda: Serialize codec probe and remove on the same bus Cen Zhang
2026-10-31 5:14 ` [PATCH v4 2/5] ALSA: core: Add the card file while looking up a minor Cen Zhang
2026-10-31 5:14 ` [PATCH v4 3/5] ALSA: pcm: Add the file to the card while looking up the minor Cen Zhang
2026-10-31 5:14 ` [PATCH v4 4/5] ALSA: pcm: Refuse to open a disconnected PCM Cen Zhang
2026-10-31 5:14 ` [PATCH v4 5/5] ALSA: hda: Wait for the files of the codec PCMs before freeing them Cen Zhang
2026-11-06 14:18 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jymqoxfz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=baijiaju1990@gmail.com \
--cc=jjzuming@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®