From: Takashi Iwai <tiwai@suse.de>
To: Harin Lee <me@harin.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ALSA: ctxfi: Fix memory leakage when clearing DAO input mappers
Date: Sat, 03 Oct 2026 11:15:42 +0200 [thread overview]
Message-ID: <87jynzxhz5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261001144501.3050667-2-me@harin.net>
On Thu, 01 Oct 2026 16:45:01 +0200,
Harin Lee wrote:
>
> Commit e576e7843c0d ("ALSA: ctxfi: Simplify dao_clear_{left,right}_input() functions")
> centralized the DAO input mapper clearing logic in
> dao_clear_input(), but omitted the kfree() calls.
>
> It removes the mapper entries from the list and sets their pointers
> to NULL without freeing the allocated array. This leaks memory each
> time dao_clear_input() is called.
>
> Store the base pointer of the allocation before clearing the mapper
> entries and free the array after removing entries from the list.
>
> Fixes: e576e7843c0d ("ALSA: ctxfi: Simplify dao_clear_{left,right}_input() functions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Harin Lee <me@harin.net>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-03 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:45 [PATCH 0/1] " Harin Lee
2026-10-01 14:45 ` [PATCH 1/1] " Harin Lee
2026-10-03 9:15 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jynzxhz5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=me@harin.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®