mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath9k: validate RX stream lengths before copying
Date: Wed, 09 Sep 2026 12:43:25 +0200	[thread overview]
Message-ID: <87jyoug0xe.fsf@toke.dk> (raw)
In-Reply-To: <6cda5b2b-34b0-430c-bff3-635df1080312@oss.qualcomm.com>

Jeff Johnson <jeff.johnson@oss.qualcomm.com> writes:

> On 9/4/2026 4:59 AM, Toke Høiland-Jørgensen wrote:
>> Pengpeng Hou <pengpeng@iscas.ac.cn> writes:
>> 
>>> ath9k_hif_usb_rx_stream() reads RX stream headers and copies payload
>>> bytes from the current skb into newly allocated skbs. It also completes
>>> packets that span two URBs by copying the remaining bytes from the next
>>> skb into hif_dev->remain_skb.
>>>
>>> The parser checked the stream tag and an upper bound on pkt_len, but it
>>> did not first prove that the fixed header, the non-fragmented payload,
>>> or the bytes needed to complete a fragmented packet are present in the
>>> current skb. Reject malformed RX stream data before reading or copying
>>> beyond the received buffer.
>>>
>>> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
>> 
>> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
>
> Can you check the v2: 20260814075716.18804-1-pengpeng@iscas.ac.cn

Meh, the extra zeroing in v2 doesn't seem to serve any purpose, so let's
just go with this one...

-Toke

      reply	other threads:[~2026-09-09 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  5:38 Pengpeng Hou
2026-09-04 11:59 ` Toke Høiland-Jørgensen
2026-09-08 22:20   ` Jeff Johnson
2026-09-09 10:43     ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jyoug0xe.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pengpeng@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®