From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A5584432F6 for ; Tue, 11 Aug 2026 13:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455346; cv=none; b=KFKWBW9mOBIBN8Omt9ErstpN/iWZTg9Le3wMyKZ84WjqB0JzR9MvTud//A2XdFxTtmu3/hFbgfGDPoAKR3lOMqTKHhJN1kObr1MBjF1ssETqHZT/IQ4oY/grdesdwIzwZghn9BJbHTcZr1b/DsEYulg2L9jNFyS2TnvLPqw0M0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455346; c=relaxed/simple; bh=uHq76Mz1zumEZXiEw9z1fnCyVGkFhFaVquwppxWbVLQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Gh+jnqH37NdSl5g4MC5aghjFwy1YcQvYAJ0fadlCoQ8N4FZBQtx2A/Kd7zC/cEfsLoApha1u8kyM5ZQkEloIdPmKiwi5Sw0N6la5eTAsy05HxL39Z5kyZEWacXaJxDTyZV8gfCtSCGntjuqWcjK5KNJQndg31cr9U6pmfVCrS98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZMYUkVKl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZMYUkVKl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55AC41F000E9; Tue, 11 Aug 2026 13:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786455331; bh=hASd2Y4u3Hb8QTayxMPjZ5FS9B/nNZPc2KtaNXRLThk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ZMYUkVKlMRuQ+/k1d4fr2Im1d8PNNM2sstLQDAb3jiSZU5A6VlFvyqa2/Cavwa0Uj U7GH2nymbt4JNTJ4wk4PEEKyGMf4tR5vS2IAr/syoUU9WQx+B16CcxQHl6xj9jnT2Z T231DmgsXdKHYnYbn6j4oPSvaR/qczuH6qt7Eh2YMjkyecjfOy1Q3S0Xp0OKC3kHDP 6gP15fvlgU+JElWtRcZTTy6YAx/qxbr60rSlHekprBY1P2yzJo7yJBZ+9/o9/f/0LI U73abdWitQqmgcfp7XIOtu2eomOizdFmyeDJ5bqaBFF8dUmeQDrsEUmta3Stpupp4z RtwClysDELqAA== From: Thomas Gleixner To: "Paul E. McKenney" , Anna-Maria Behnsen , Frederic Weisbecker Cc: "Peter Zijlstra (Intel)" , linux-kernel@vger.kernel.org, kernel-team@meta.com, "Paul E. McKenney" Subject: Re: [PATCH RFC 1/9] hrtimer: Mark data-racy accesses to hrtimer_sleeper ->task field In-Reply-To: <20260731004019.3530210-1-paulmck@kernel.org> References: <20260731004019.3530210-1-paulmck@kernel.org> Date: Tue, 11 Aug 2026 15:35:27 +0200 Message-ID: <87jypwn5k0.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jul 30 2026 at 17:40, Paul E. McKenney wrote: > static enum hrtimer_restart hrtimer_wakeup(struct hrtimer *timer) > { > struct hrtimer_sleeper *t = container_of(timer, struct hrtimer_sleeper, timer); > - struct task_struct *task = t->task; > + struct task_struct *task = hrtimer_sleeper_task_get(t); > > - t->task = NULL; > + hrtimer_sleeper_task_set(t, NULL); To be honest, I find these helper functions more confusing that useful unless you make the task member private at the very end of the series once everything is converted over. If not, then what's wrong with a plain READ/WRITE_ONCE()? Thanks, tglx