From: Jonathan Corbet <corbet@lwn.net>
To: Sanjai <sanjai@myyahoo.com>
Cc: mchehab+huawei@kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, Sanjai <sanjai@myyahoo.com>
Subject: Re: [PATCH] scripts/lib/kdoc: apply pending TODO renames
Date: Wed, 11 Mar 2026 08:53:11 -0600 [thread overview]
Message-ID: <87jyviquy0.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260311143255.171980-1-sanjai@myyahoo.com>
Sanjai <sanjai@myyahoo.com> writes:
> The TODO comments requested these renames after the removal of
> kernel-doc.pl.
> kernel-doc.pl was removed in commit 683e8cbaba7f
> ("docs: remove kernel-doc.pl"),
>
> so the renames can now be applied:
>
> - rename emit_msg() to emit_message()
> - rename output_declaration() to store_declaration()
>
> Signed-off-by: Sanjai <sanjai@myyahoo.com>
> ---
> tools/lib/python/kdoc/kdoc_parser.py | 86 ++++++++++++++--------------
> 1 file changed, 42 insertions(+), 44 deletions(-)
Perhaps the new name is a better one, but what is the real benefit to
the kernel from this much churn. That is an especially pertinent
question when there is a lot of other kernel-doc work going on that will
surely end up conflicting with this sort of change...?
Thanks,
jon
prev parent reply other threads:[~2026-03-11 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260311143255.171980-1-sanjai.ref@myyahoo.com>
2026-03-11 14:32 ` Sanjai
2026-03-11 14:53 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyviquy0.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sanjai@myyahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®