From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C301EE49A5 for ; Mon, 21 Aug 2023 09:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234295AbjHUJPE (ORCPT ); Mon, 21 Aug 2023 05:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbjHUJPD (ORCPT ); Mon, 21 Aug 2023 05:15:03 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED3DEC4 for ; Mon, 21 Aug 2023 02:15:01 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA77F205D1; Mon, 21 Aug 2023 09:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692609300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l8hLfrEfmkYRdElw8Vnuc1F8YeyR+EXUajtCjcvHBUg=; b=EF1EJYsEonKlQFeYcgRZxP+lFxb9MGXTIN3ApbeZsK+xRyiPL94m7Eh6veWXzhXUtXCbjF lSwUzgVdIRZqgUZQCs+HNtFiolerVLKf0vJAtkz42byw7lpZfZBN12CSb9vjIFzavSjazr jevmyudPmxrJJy30glO0DmROvghQyms= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692609300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l8hLfrEfmkYRdElw8Vnuc1F8YeyR+EXUajtCjcvHBUg=; b=QIwWoN2vdqVRUjKakqnuINngn/d1tWypJDIyf3bCBH14x8YIVjvfDm0TXlsRHMEoHn4Jv/ RvhHrf5NYxmiSsBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 485231330D; Mon, 21 Aug 2023 09:15:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hGv9DxQr42TYVQAAMHmgww (envelope-from ); Mon, 21 Aug 2023 09:15:00 +0000 Date: Mon, 21 Aug 2023 11:14:59 +0200 Message-ID: <87jzto92p8.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: Pierre-Louis Bossart , Shenghao Ding , robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, mengdong.lin@intel.com, baojun.xu@ti.com, thomas.gfeller@q-drop.com, peeyush@ti.com, navada@ti.com, broonie@kernel.org, gentuser@gmail.com Subject: Re: [PATCH v3 2/2] ALSA: hda/tas2781: Add tas2781 HDA driver In-Reply-To: References: <20230818085558.1431-1-shenghao-ding@ti.com> <20230818085558.1431-2-shenghao-ding@ti.com> <4c1b44b5-995a-fac7-a72b-89b8bf816dd2@linux.intel.com> <87jztq9iqv.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Aug 2023 11:06:20 +0200, Andy Shevchenko wrote: > > On Sun, Aug 20, 2023 at 11:16:08AM +0200, Takashi Iwai wrote: > > On Fri, 18 Aug 2023 19:01:16 +0200, > > Andy Shevchenko wrote: > > > On Fri, Aug 18, 2023 at 11:00:34AM -0500, Pierre-Louis Bossart wrote: > > ... > > > > > > +static void tas2781_fixup_i2c(struct hda_codec *cdc, > > > > > + const struct hda_fixup *fix, int action) > > > > > +{ > > > > > + tas2781_generic_fixup(cdc, action, "i2c", "TIAS2781"); > > > > > > > > TI ACPI ID is TXNW > > > > > > > > https://uefi.org/ACPI_ID_List?search=TEXAS > > > > > > > > There's also a PNP ID PXN > > > > > > > > https://uefi.org/PNP_ID_List?search=TEXAS > > > > > > > > "TIAS" looks like an invented identifier. It's not uncommon but should > > > > be recorded with a comment if I am not mistaken. > > > > > > > > > +} > > > > > > Thank you, but actually it's a strong NAK to this even with the comment. > > > We have to teach people to follow the specification (may be even hard way). > > > > > > So where did you get the ill-formed ACPI ID? > > > Is Texas Instrument aware of this? > > > Can we have a confirmation letter from TI for this ID, please? > > > > This is used already for products that have been long in the market, > > so it's way too late to correct it, I'm afraid. > > > > What we can do is to get the confirmation from TI, complain it, and > > some verbose comment in the code, indeed. > > Oh, no! Who made that ID, I really want to point that at their faces. > Look at the Coreboot (successful) case, they created something, but > in time asked and then actually fixed the ill-formed ID (that was for > one of RTC chips). > > For this, please make sure that commit message has that summary, explaining that > - states that ID is ill-formed > - states that there are products with it (DSDT excerpt is a must) > - lists (a few?) products where that ID is used > - ideally explains who invented that and Cc them to the patch, so they will > know they made a big mistake Sure, we should complain further and ask them that such a problem won't happen again. I'm 100% for it. But the fact is that lots of machines have been already shipped with this ID since long time ago, and 99.99% of them have been running on Windows. Hence I expect that the chance to get a corrected ID is very very low, and waiting for the support on Linux until the correction of ID actually happens makes little sense; that's my point. Takashi