From: Takashi Iwai <tiwai@suse.de>
To: Lukasz Tyl <ltyl@hem-e.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, pgorgon@hem-e.com
Subject: Re: [PATCH] sound: usb: quirks: add flag for HEM devices to enable native DSD playback
Date: Wed, 14 Jun 2023 13:39:24 +0200 [thread overview]
Message-ID: <87jzw69ssz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230614113350.25607-1-ltyl@hem-e.com>
On Wed, 14 Jun 2023 13:33:50 +0200,
Lukasz Tyl wrote:
>
> This commit adds new DEVICE_FLG with QUIRK_FLAG_DSD_RAW and Vendor Id for
> HEM devices which supports native DSD. Prior to this change Linux kernel
> was not enabling native DSD playback for HEM devices, and as a result,
> DSD audio was being converted to PCM "on the fly". HEM devices,
> when connected to the system, would only play audio in PCM format,
> even if the source material was in DSD format. With the addition of new
> VENDOR_FLG in the quircks.c file, the devices are now correctly
> recognized, and raw DSD data is transmitted to the device,
> allowing for native DSD playback.
>
> Signed-off-by: Lukasz Tyl <ltyl@hem-e.com>
> ---
> sound/usb/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 3ecd1ba7fd4b..1414bf15ac21 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2197,6 +2197,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
> QUIRK_FLAG_DSD_RAW),
> VENDOR_FLG(0xc502, /* HiBy devices */
> QUIRK_FLAG_DSD_RAW),
> + VENDOR_FLG(0x3336, /* HEM devices */
> + QUIRK_FLAG_DSD_RAW),
The entry is sorted in vendor id number. Could you try to put at the
right position?
thanks,
Takashi
prev parent reply other threads:[~2023-06-14 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:33 Lukasz Tyl
2023-06-14 11:39 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzw69ssz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltyl@hem-e.com \
--cc=perex@perex.cz \
--cc=pgorgon@hem-e.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®