From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C39C432BE for ; Thu, 12 Aug 2021 15:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C53060F35 for ; Thu, 12 Aug 2021 15:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbhHLPPT (ORCPT ); Thu, 12 Aug 2021 11:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235730AbhHLPPS (ORCPT ); Thu, 12 Aug 2021 11:15:18 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31445C061756; Thu, 12 Aug 2021 08:14:53 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id DF7E52CC; Thu, 12 Aug 2021 15:14:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net DF7E52CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1628781293; bh=zTi3JZ2hzc1lT/Vj6KKa1g4uFSkByqMdcflCMODKAn8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tFVycUJdkpz8j/ZNyfUOB64cdsKFgs9s4Fu3wGX2biAU6/BBojS/4zP1i84/nIqeU YGZdW+DJ7q3fYN1BKSIdPoG+k9tLw9/UMbk8O4cH/pppKGlNdEPTelYxzAmH7My5SU hxQTHTI3gb3d6w1fUbmlaVSkDxvsGVm0K4qtV+pleD6aNesOqhOE3rB36TBM8yYZv/ 0cqSRFOe8bfvGFlsVxX1aJ1BavCeSjgoCcrERv6+hWe9L+Z2W6MHUrt1bSeOWZLLw4 /USjaWCHM1+q9gQCYdObp4MDUr+TrWuhUAZvWi2COFlnPu6lDLpGuiGvvPlotfFAvN vxT7JgMLVMosw== From: Jonathan Corbet To: Akira Yokosawa Cc: "Wu X.C." , SeongJae Park , Hu Haowen , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH v3 6/9] docs: pdfdocs: One-half spacing for CJK translations In-Reply-To: References: <8e70e5ed-c0d9-a0f0-6640-a0f1ebdda6d4@gmail.com> <87im0a207r.fsf@meer.lwn.net> Date: Thu, 12 Aug 2021 09:14:52 -0600 Message-ID: <87k0kqzocz.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Akira Yokosawa writes: > On Thu, 12 Aug 2021 08:42:48 -0600, Jonathan Corbet wrote: >> Akira Yokosawa writes: >> >>> On Mon, 2 Aug 2021 18:56:16 +0900, Akira Yokosawa wrote: >>>> CJK documents are much easier to read with a wider baseline stretch. >>>> Applying the onehalfspacing option of "setspace" package looks >>>> reasonable. >>>> >>>> Note: \usepackage{setspace} needs to be before that of hyperref in the >>>> preamble. The 'extrapackages' key (available since Sphinx 2.3) is for >>>> this purpose. >>> >>> Sphinx versions < 2.3 ignore 'extrapackages' and generate LaTeX >>> sources without setspace package. >>> Obviously, building such LaTeX sources will end up in the error of: >>> >>> ! Undefined control sequence. >>> \kerneldocCJKoff ...exeCJKinactive \singlespacing >>> >>> Current requirement to build pdfdocs is Sphinx 2.4.4, but LaTeX >>> sources generated by 1.7.9 can at least be built prior to this change. >>> >>> Jon, Mauro, do you think this is a regression? >> >> Having the build just fail that way isn't really a good thing...it would >> be far better to do the baseline tweaking only with versions of sphinx >> that support it or, failing that, to at least refuse to build with a >> suitably informative message. > > Hi Jon, > > This issue is fixed in v4 of the patch set. > Can you please consider pulling v4? > > I have tested it against Sphinx versions 1.7.9, 2.4.4, and 4.1.2. Ouch, weird...I definitely got v4, but somehow it managed to evade my docs folder. Apologies for that; I've just applied that version. Thanks, jon