From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D77C433E6 for ; Tue, 23 Feb 2021 00:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF47564DFD for ; Tue, 23 Feb 2021 00:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbhBWAyv (ORCPT ); Mon, 22 Feb 2021 19:54:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhBWAyt (ORCPT ); Mon, 22 Feb 2021 19:54:49 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 143EFC061574 for ; Mon, 22 Feb 2021 16:54:08 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Dl0tB6d2Dz9sS8; Tue, 23 Feb 2021 11:53:54 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1614041645; bh=aa+K8Nsatfk9ECjgauAQRY0LNVMvN0lgz7Bn7cRNvPI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OoK4jrhrRNDhE5HESbrR/JIr1yTHMJvXEhNrsVZ6kTWFctv0wc11QiChVTa4ZoNrV KhwyC3IONpVjkhOhDK/UzhSaaoJZxo/AoHce8c4QYkCAReD/uePXk0m76fdDIzG+y3 IzYUe4tQlrZh/hSDKOGiRZkUDzvet2ZmoX9aLrFwXDpotGFY9KSI3NN9ptcuR82SPW Iw2+VmOmnKt9G1zabmvgLNChXNxB7Mubm6hq0bfb3h1wZTfGyoH5iPnF8Ldr3ncHFe cmNf3K0RUMRlOB0H7MDPB4ndf5fA/KeQmxFzNeBfq9TU9nI2aCbpJFKaEgGLiWDNFt RGbsCzc6NPBSw== From: Michael Ellerman To: Oliver O'Halloran , Linus Torvalds Cc: Alexey Kardashevskiy , Ananth N Mavinakayanahalli , "Aneesh Kumar K.V" , Athira Jajeev , Qian Cai , Christophe Leroy , =?utf-8?Q?C=C3=A9dric?= Le Goater , cmr@codefail.de, cy.fan@huawei.com, eerykitty@gmail.com, Markus Elfring , Florian Fainelli , Frederic Barrat , ganeshgr@linux.ibm.com, Haren Myneni , Hari Bathini , jiapeng.chong@linux.alibaba.com, Pingfan Liu , kjain@linux.ibm.com, Linux Kernel Mailing List , linuxppc-dev , Michal Suchanek , Nathan Lynch , Nick Piggin , Po-Hsu Lin , Randy Dunlap , sandipan@linux.ibm.com, skirmisher@protonmail.com, Bhaskar Chowdhury , Zheng Yongjun , Rob Herring , Mark Brown Subject: Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag In-Reply-To: References: <87o8gctii6.fsf@mpe.ellerman.id.au> Date: Tue, 23 Feb 2021 11:53:53 +1100 Message-ID: <87k0qztxi6.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Oliver O'Halloran" writes: > On Tue, Feb 23, 2021 at 9:44 AM Linus Torvalds > wrote: >> >> On Mon, Feb 22, 2021 at 4:06 AM Michael Ellerman wrote: >> > >> > Please pull powerpc updates for 5.12. >> >> Pulled. However: >> >> > mode change 100755 => 100644 tools/testing/selftests/powerpc/eeh/eeh-functions.sh >> > create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-aware.sh >> > create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-unaware.sh >> >> Somebody is being confused. >> >> Why create two new shell scripts with the proper executable bit, and >> then remove the executable bit from an existing one? >> >> That just seems very inconsistent. > > eeh-function.sh just provides some helper functions for the other > scripts and doesn't do anything when executed directly. I thought > making it non-executable made sense. Yeah I think it does make sense. It just looks a bit odd in the diffstat like this. Maybe if we called it lib.sh it would be more obvious? cheers